Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Containerapp] Support debug console #7945
base: main
Are you sure you want to change the base?
[Containerapp] Support debug console #7945
Changes from all commits
5232b7c
c28952c
4360f4a
a1b27b5
a81c8ef
679397a
faf303c
549bdb8
a5fc827
bede964
b250f48
5a3d550
ccf5f3f
c60b4df
23aae02
18a0000
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can list revisions here and see: 1) if we got 404 error or None object then the container app doesnt exist 2) if we got an empty array then the container app exists but doesnt have any revisions
and the revision list data could be reused in checking user input parameter "targetContainer"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO. List revisions will return all revision, this is not a good choice. If customer has lots of revisions, the payload will be big enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally the number of revisions in a single container app wont be too much. currently only 3.7% of container apps are in multiple active revision mode.
btw if you take a closer look at the container app payload and revision payload you will see container app is much larger than just a revision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this API will return all the revisions, which are active or not active.