{CI} Fix linter failures #19147
Merged
{CI} Fix linter failures #19147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhoxing-ms
requested review from
evelyn-ys,
jsntcy,
Juliehzl and
kairu-ms
as code owners
evelyn-ys
approved these changes
Aug 6, 2021
|
CI |
zhoxing-ms
added a commit
that referenced
this pull request
Aug 18, 2021
…to support auto upgrade (#18825) * implementedCodeFromPreviousPRs * adding ManagedClusterAutoUpgradeProfile code * adding test record * Fix linter failures (#19116) (#19147) Co-authored-by: Yishi Wang <yishiwang@microsoft.com> * Handle unsupported and no_effect change types (#19144) * [Batch] Upgrade api-version to v2021-06-01 (#19100) * Improve nodepool help text for OS Disk options (#19073) * {AKS} Refactor acs module: add test cases for sub-command `create` (#19026) * add test for autoscaler * add test for loadbalancer * add test for node public ip * add test for network cidr * update create default test * add test for create attach acr * add AKSCustomRoleBasedServicePrincipalPreparer * update test ingress appgw * add test case for outbound type udr * add test for node_osdisk_diskencryptionset * add test for enable-encryption-at-host, enable-azure-rbac, disable-rbac and dns-service-ip * add test for workspace-resource-id * add recordings * update recordings * [SQL] az sql mi update: Add --subnet and --vnet-name parameters to support the cross subnet update SLO (#18886) * Update sql track2 * Update commands.py update begin_delete * update setter_name to pass sdk validation * replace_all_delete * pass az self-check * update recording tests * fix all begin_xyz issue * run test to unblock some issues * pass SqlServerMSSupportScenarioTest * change region to pass tests * pass LTR test * add recorded tests for MI * update db_rename parameters * pass db management tests * address aad tests * pass sql server aad * revert azure-mgmt-netapp version change * record test after rebase * add three passed tests * modify short term policy * complete another three tests * pass tde test * pass two more tests * Update custom.py * pass two more tests * pass classification test * pass long and short backup * update test file to match new config * pass server and db security tests * record test_sql_db_sensitivity_classifications again * update MI tests * pass MI tests * pass tests * modify instance_pool_test * Iteration 1: - Adding support for cross subnet update SLO * Iteration 2: - Removing the change from History.rst file * Iteration 3: - Fixing merge errors * Iteration 4: - Removing merge errors * Iteration 5: - Removing merge errors * Iteration 6: - Fixed merge errors * Iteration 7: - Fix merge errors * Iteration 7: - Fixed CLI style issue - removed two trailing spaces - Fixed CLI linter issue - fixed the cross-subnet update slo command in _help.py Co-authored-by: Ji Wang <wangjiprc@gmail.com> Co-authored-by: Nemanja <nemanjas@microsoft.ccom> * [ACR] `acr create/update`: Add new parameter `--allow-exports` to support export (#19065) * Update azure-mgmt-containerregistry from 8.0.0 to 8.1.0. Add support for export disable. * Add acr export policy tests style fix * re-record acr dependent tests * style: disable too many locals * fix style issue Co-authored-by: Tosin Adewale <oluwatosin.adewale@microsoft.com> * Fix linter failures (#19116) * {Packaging} Drop `mock` library (#19024) * Upgrades Batch SDKs * Python Data Plane SDK: 11.0.0 * Python Management Plane SDK: 16.0.0 * Fixes data plane tests * New `outbound-endpoints` and `list-skus` commands * `az batch account outbound-endpoints` * `az batch location list-skus` * Updates tests and session recordings * Fixes help linting Co-authored-by: Ismayil <ismayilmirzeli@gmail.com> Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: v-nestan <58415436+v-nestan@users.noreply.github.com> Co-authored-by: Ji Wang <wangjiprc@gmail.com> Co-authored-by: Nemanja <nemanjas@microsoft.ccom> Co-authored-by: Tosin Adewale <oladewal@microsoft.com> Co-authored-by: Tosin Adewale <oluwatosin.adewale@microsoft.com> Co-authored-by: jiasli <4003950+jiasli@users.noreply.github.com> Co-authored-by: Yishi Wang <yishiwang@microsoft.com> Co-authored-by: David Watrous <509299+dpwatrous@users.noreply.github.com> Co-authored-by: Shiran Pasternak <shiran.pasternak@microsoft.com> * {Release} Hotfix: Release 2.27.1 (#19187) * Hotfix for 2.27.1 * Update src/azure-cli/HISTORY.rst Co-authored-by: Yishi Wang <yishiwang@microsoft.com> Co-authored-by: Yishi Wang <yishiwang@microsoft.com> * change to direct enums Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * fixing PR comments * change to auto_upgrade_channels * test_aks_create_with_auto_upgrade_channel * Revert "test_aks_create_with_auto_upgrade_channel" This reverts commit c1affbf. * Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI" This reverts commit 4121a33, reversing changes made to c7f92e3. * Revert "Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI"" This reverts commit ec9cd69. * Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI" This reverts commit 4121a33, reversing changes made to c7f92e3. * Revert "Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI"" This reverts commit 0ef331c. * Revert "Revert "Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI""" This reverts commit cd47cb0. * Revert "Revert "Revert "Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI"""" This reverts commit 8d8f80f. * Revert "Handle unsupported and no_effect change types (#19144)" This reverts commit 71456b1. * Revert "Revert "Handle unsupported and no_effect change types (#19144)"" This reverts commit effe159. * Revert "{Release} Hotfix: Release 2.27.1 (#19187)" This reverts commit da3ff65. * Revert "[Batch] Upgrade api-version to v2021-06-01 (#19100)" This reverts commit ed4e903. * Revert "Handle unsupported and no_effect change types (#19144)" This reverts commit 71456b1. * running new test * remove yaml * ran test Co-authored-by: Charlie McBride <Charlie.McBride@microsoft.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> Co-authored-by: Yishi Wang <yishiwang@microsoft.com> Co-authored-by: Shenglong Li <shenglong.li@outlook.com> Co-authored-by: Rena <cRui861@users.noreply.github.com> Co-authored-by: Ismayil <ismayilmirzeli@gmail.com> Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: v-nestan <58415436+v-nestan@users.noreply.github.com> Co-authored-by: Ji Wang <wangjiprc@gmail.com> Co-authored-by: Nemanja <nemanjas@microsoft.ccom> Co-authored-by: Tosin Adewale <oladewal@microsoft.com> Co-authored-by: Tosin Adewale <oluwatosin.adewale@microsoft.com> Co-authored-by: jiasli <4003950+jiasli@users.noreply.github.com> Co-authored-by: David Watrous <509299+dpwatrous@users.noreply.github.com> Co-authored-by: Shiran Pasternak <shiran.pasternak@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from #19116 for hot fix
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.