Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview #10302

Merged
merged 2 commits into from
Jul 31, 2020
Merged

[Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview #10302

merged 2 commits into from
Jul 31, 2020

Conversation

bowen5
Copy link
Contributor

@bowen5 bowen5 commented Jul 30, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 30, 2020

[Staging] Swagger Validation Report

BreakingChange: 6 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2793:9
Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2793:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2798:9
Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2797:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3009:9
Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3007:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2793:9
Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2793:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2798:9
Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2797:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3009:9
Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3007:9
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 914ce83 with merge commit f50289e. SDK Automation 13.0.17.20200619.4
  • ⚠️azure-mgmt-appplatform [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-appplatform
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-appplatform
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 31.617% size of original (original: 41744 chars, delta: 13198 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model ServiceResource has a new parameter sku
    [ChangeLog]   - Model OperationDetail has a new parameter is_data_action
    [ChangeLog]   - Model AppResource has a new parameter location
    [ChangeLog]   - Model AppResource has a new parameter identity
    [ChangeLog]   - Model AppResourceProperties has a new parameter https_only
    [ChangeLog]   - Model AppResourceProperties has a new parameter fqdn
    [ChangeLog]   - Added operation group CertificatesOperations
    [ChangeLog]   - Added operation group SkuOperations
    [ChangeLog]   - Added operation group CustomDomainsOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Operation AppsOperations.update has a new signature
    [ChangeLog]   - Operation AppsOperations.create_or_update has a new signature
    [ChangeLog]   - Model OperationDetail no longer has parameter data_action

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 914ce83 with merge commit f50289e. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-appplatform [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/appPlatformManagementClient.js → ./dist/arm-appplatform.js...
    [npmPack] created ./dist/arm-appplatform.js in 493ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-appplatform@1.0.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 2.1kB   esm/appPlatformManagementClient.js             
    [npmPack] npm notice 2.7kB   esm/appPlatformManagementClientContext.js      
    [npmPack] npm notice 11.0kB  esm/operations/apps.js                         
    [npmPack] npm notice 1.0kB   esm/models/appsMappers.js                      
    [npmPack] npm notice 170.0kB dist/arm-appplatform.js                        
    [npmPack] npm notice 58.2kB  dist/arm-appplatform.min.js                    
    [npmPack] npm notice 7.7kB   esm/operations/bindings.js                     
    [npmPack] npm notice 991B    esm/models/bindingsMappers.js                  
    [npmPack] npm notice 6.2kB   esm/operations/certificates.js                 
    [npmPack] npm notice 999B    esm/models/certificatesMappers.js              
    [npmPack] npm notice 9.1kB   esm/operations/customDomains.js                
    [npmPack] npm notice 1.1kB   esm/models/customDomainsMappers.js             
    [npmPack] npm notice 21.4kB  esm/operations/deployments.js                  
    [npmPack] npm notice 1.0kB   esm/models/deploymentsMappers.js               
    [npmPack] npm notice 345B    esm/models/index.js                            
    [npmPack] npm notice 590B    esm/operations/index.js                        
    [npmPack] npm notice 54.1kB  esm/models/mappers.js                          
    [npmPack] npm notice 2.3kB   esm/operations/operations.js                   
    [npmPack] npm notice 560B    esm/models/operationsMappers.js                
    [npmPack] npm notice 3.5kB   esm/models/parameters.js                       
    [npmPack] npm notice 995B    rollup.config.js                               
    [npmPack] npm notice 17.1kB  esm/operations/services.js                     
    [npmPack] npm notice 1.1kB   esm/models/servicesMappers.js                  
    [npmPack] npm notice 2.4kB   esm/operations/skuOperations.js                
    [npmPack] npm notice 584B    esm/models/skuOperationsMappers.js             
    [npmPack] npm notice 1.7kB   package.json                                   
    [npmPack] npm notice 457B    tsconfig.json                                  
    [npmPack] npm notice 881B    esm/appPlatformManagementClient.d.ts.map       
    [npmPack] npm notice 1.2kB   esm/appPlatformManagementClient.js.map         
    [npmPack] npm notice 521B    esm/appPlatformManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/appPlatformManagementClientContext.js.map  
    [npmPack] npm notice 3.5kB   esm/operations/apps.d.ts.map                   
    [npmPack] npm notice 5.6kB   esm/operations/apps.js.map                     
    [npmPack] npm notice 531B    esm/models/appsMappers.d.ts.map                
    [npmPack] npm notice 544B    esm/models/appsMappers.js.map                  
    [npmPack] npm notice 352.4kB dist/arm-appplatform.js.map                    
    [npmPack] npm notice 48.8kB  dist/arm-appplatform.min.js.map                
    [npmPack] npm notice 3.7kB   esm/operations/bindings.d.ts.map               
    [npmPack] npm notice 4.6kB   esm/operations/bindings.js.map                 
    [npmPack] npm notice 526B    esm/models/bindingsMappers.d.ts.map            
    [npmPack] npm notice 539B    esm/models/bindingsMappers.js.map              
    [npmPack] npm notice 2.8kB   esm/operations/certificates.d.ts.map           
    [npmPack] npm notice 3.6kB   esm/operations/certificates.js.map             
    [npmPack] npm notice 534B    esm/models/certificatesMappers.d.ts.map        
    [npmPack] npm notice 547B    esm/models/certificatesMappers.js.map          
    [npmPack] npm notice 4.3kB   esm/operations/customDomains.d.ts.map          
    [npmPack] npm notice 5.3kB   esm/operations/customDomains.js.map            
    [npmPack] npm notice 562B    esm/models/customDomainsMappers.d.ts.map       
    [npmPack] npm notice 575B    esm/models/customDomainsMappers.js.map         
    [npmPack] npm notice 5.8kB   esm/operations/deployments.d.ts.map            
    [npmPack] npm notice 9.9kB   esm/operations/deployments.js.map              
    [npmPack] npm notice 545B    esm/models/deploymentsMappers.d.ts.map         
    [npmPack] npm notice 558B    esm/models/deploymentsMappers.js.map           
    [npmPack] npm notice 22.2kB  esm/models/index.d.ts.map                      
    [npmPack] npm notice 290B    esm/operations/index.d.ts.map                  
    [npmPack] npm notice 126B    esm/models/index.js.map                        
    [npmPack] npm notice 305B    esm/operations/index.js.map                    
    [npmPack] npm notice 3.0kB   esm/models/mappers.d.ts.map                    
    [npmPack] npm notice 30.4kB  esm/models/mappers.js.map                      
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map             
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map               
    [npmPack] npm notice 277B    esm/models/operationsMappers.d.ts.map          
    [npmPack] npm notice 290B    esm/models/operationsMappers.js.map            
    [npmPack] npm notice 822B    esm/models/parameters.d.ts.map                 
    [npmPack] npm notice 2.7kB   esm/models/parameters.js.map                   
    [npmPack] npm notice 5.6kB   esm/operations/services.d.ts.map               
    [npmPack] npm notice 9.1kB   esm/operations/services.js.map                 
    [npmPack] npm notice 575B    esm/models/servicesMappers.d.ts.map            
    [npmPack] npm notice 588B    esm/models/servicesMappers.js.map              
    [npmPack] npm notice 1.0kB   esm/operations/skuOperations.d.ts.map          
    [npmPack] npm notice 1.5kB   esm/operations/skuOperations.js.map            
    [npmPack] npm notice 283B    esm/models/skuOperationsMappers.d.ts.map       
    [npmPack] npm notice 296B    esm/models/skuOperationsMappers.js.map         
    [npmPack] npm notice 3.4kB   README.md                                      
    [npmPack] npm notice 1.4kB   esm/appPlatformManagementClient.d.ts           
    [npmPack] npm notice 2.2kB   src/appPlatformManagementClient.ts             
    [npmPack] npm notice 943B    esm/appPlatformManagementClientContext.d.ts    
    [npmPack] npm notice 2.4kB   src/appPlatformManagementClientContext.ts      
    [npmPack] npm notice 10.8kB  esm/operations/apps.d.ts                       
    [npmPack] npm notice 18.6kB  src/operations/apps.ts                         
    [npmPack] npm notice 699B    esm/models/appsMappers.d.ts                    
    [npmPack] npm notice 1.0kB   src/models/appsMappers.ts                      
    [npmPack] npm notice 11.4kB  esm/operations/bindings.d.ts                   
    [npmPack] npm notice 18.7kB  src/operations/bindings.ts                     
    [npmPack] npm notice 681B    esm/models/bindingsMappers.d.ts                
    [npmPack] npm notice 1.0kB   src/models/bindingsMappers.ts                  
    [npmPack] npm notice 8.5kB   esm/operations/certificates.d.ts               

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 30, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@njuCZ njuCZ added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 31, 2020
@njuCZ njuCZ merged commit f50289e into Azure:master Jul 31, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 31, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 31, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@bowen5 bowen5 deleted the dev-appplatform-Microsoft.AppPlatform-2019-05-01-preview branch July 31, 2020 03:53
iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (29 commits)
  Add preAttack tactic to swagger (Azure#10332)
  Add Url Signing action definition (Azure#10326)
  [Synapse] Support long running operation and add subclass of Activity in artifact (Azure#10270)
  Add native blob soft delete (Azure#10308)
  Fix Microsoft.Resources naming issue (Azure#10318)
  Notebooks swagger spec (Azure#9841)
  Add network profile in Spring payload. (Azure#10313)
  Fix output-folder for go SDK in timeseriesinsight (Azure#10300)
  Alias Put Subscription API (Azure#10205)
  resource-resource-2019-03-01-python-config (Azure#10314)
  New Api version 2020-06-15- fixing certificate put/get issues with ARM  (Azure#10251)
  [DataFactory] Support source sink level staging (Azure#10290)
  Added swagger files for PostgreSQL Flexible Server preview (Azure#10020)
  [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview (Azure#10302)
  Adding Untracked Public Maintenance Config Resource Type (Azure#10281)
  add assignment resource id to the schema (Azure#10309)
  [datashare] sort api's and definitions (Azure#10273)
  Update readme.md all-api-versions tags (Azure#10296)
  Documentation updated (Azure#10283)
  [CosmosDB] Migration support of existing containers/databases to autoscale (Azure#9258)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
…on preview/2019-05-01-preview (Azure#10302)

* Fix swagger by adding readonly for properties.

* Update samples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants