Notebooks swagger spec #9841

somu84 · 2020-06-15T21:22:48Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-pipeline-app · 2020-06-15T21:22:53Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-06-15T21:23:04Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-06-15T21:23:38Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-06-15T21:24:39Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-15T21:24:39Z

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-15T21:24:41Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-15T21:24:41Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-15T21:24:46Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-15T21:24:46Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-15T21:24:47Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-06-16T00:25:52Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-06-16T00:28:46Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-16T00:30:51Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

erich-wang · 2020-06-17T07:27:40Z

@somu84 , could you please fix the validation errors in CI check?

chiragg4u · 2020-06-20T01:30:49Z

This looks like a completely new RP, please setup meeting with the API review board and review the scenario and API model.

chiragg4u · 2020-06-20T01:31:15Z

...ion/notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/notebooks.json

+                  "type": "string"
+              }
+          ],
+          "responses": { "200" : { "description": "Success" } } 


"description": "Success" [](start = 35, length = 24)

This should return the resource.

chiragg4u · 2020-06-20T01:32:35Z

...esource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/example/NBResourceCreate.json

+    "resourceReuest": {
+      "location": "southcentralus",
+      "properties": {
+      },


you need to pass the properties in PUT

I have linked a prior PR that has been approved.
This file was added as part of that. Can we please merge that PR to master?

chiragg4u · 2020-06-20T01:32:49Z

...esource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/example/NBResourceUpdate.json

+    "resourceName": "testResource",
+    "resourceGroupName": "testRP",
+    "subscriptionId": "91e9f7ac-9c2c-4cd2-af61-1c5b57ec6c51"
+  },


What is the update?

somu84 · 2020-06-22T17:43:11Z

This looks like a completely new RP, please setup meeting with the API review board and review the scenario and API model.

Hi Chirag, we are already on-boarded to ARM. This is the PR that was approved by ARM team last year. This is a top level proxy resource. We want it to be hidden from end customers. Can we please merge that Pr to master? So that it does not look like I am creating a brand new RP.

somu84 · 2020-06-22T17:51:36Z

@somu84 , could you please fix the validation errors in CI check?

Yes, I will push the fixes to the comments today.

ravbhatnagar

@somu84 few comments

ravbhatnagar · 2020-06-23T08:02:55Z

...ion/notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/notebooks.json

+          }
+        }
+      },
+      "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Notebooks/NotebookProxies/{resourceName}/updatePrivateLinkId/{privateLinkId}": {


what is this API supposed to do?

This API is updating the resource by adding a private link Id.

...ion/notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/notebooks.json

ravbhatnagar · 2020-06-23T08:04:15Z

...ion/notebooks/resource-manager/Microsoft.Notebooks/preview/2019-10-11-preview/notebooks.json

+        "properties": {
+          "location": { "type": "string" },
+          "properties": { "$ref": "#/definitions/NotebookResourceProperties" },
+          "hostname": { "type": "string" }


this cant be a top level property, it must be moved under "properties" property

azure-pipelines · 2020-06-23T20:01:39Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-10T21:07:24Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-10T21:43:07Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-10T22:06:09Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-14T16:29:10Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-14T16:38:17Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-14T16:42:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-14T16:55:58Z

Azure Pipelines successfully started running 1 pipeline(s).

erich-wang · 2020-07-17T06:33:36Z

@somu84 , have you addressed the comments raised by @ravbhatnagar?

somu84 · 2020-07-17T22:39:23Z

@somu84 , have you addressed the comments raised by @ravbhatnagar?

Yes, I have addressed the comments from @ravbhatnagar

somu84 · 2020-07-21T01:59:03Z

@erich-wang please let me know, if there are any blocking issues, that I need to resolve?

erich-wang · 2020-07-22T06:47:20Z

@ravbhatnagar, do you have any other comments? Could you please sign off this PR ?

somu84 · 2020-07-27T17:24:46Z

Any update on this?

ravbhatnagar · 2020-07-28T00:36:25Z

signing off from ARM side.

erich-wang · 2020-07-31T05:39:08Z

@somu84, please remove WaitForARMFeedback from the title since it is approved by ARM review board, then I'll merge this PR.

somu84 · 2020-07-31T17:27:47Z

@erich-wang done!

…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (29 commits) Add preAttack tactic to swagger (Azure#10332) Add Url Signing action definition (Azure#10326) [Synapse] Support long running operation and add subclass of Activity in artifact (Azure#10270) Add native blob soft delete (Azure#10308) Fix Microsoft.Resources naming issue (Azure#10318) Notebooks swagger spec (Azure#9841) Add network profile in Spring payload. (Azure#10313) Fix output-folder for go SDK in timeseriesinsight (Azure#10300) Alias Put Subscription API (Azure#10205) resource-resource-2019-03-01-python-config (Azure#10314) New Api version 2020-06-15- fixing certificate put/get issues with ARM (Azure#10251) [DataFactory] Support source sink level staging (Azure#10290) Added swagger files for PostgreSQL Flexible Server preview (Azure#10020) [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview (Azure#10302) Adding Untracked Public Maintenance Config Resource Type (Azure#10281) add assignment resource id to the schema (Azure#10309) [datashare] sort api's and definitions (Azure#10273) Update readme.md all-api-versions tags (Azure#10296) Documentation updated (Azure#10283) [CosmosDB] Migration support of existing containers/databases to autoscale (Azure#9258) ...

* Notebooks swagger spec * New line at the end of file * Remove new line at the end * PR feedback * Fix CI errors' * Add custom words * Add readme * Renamed examples folder * Add operations API * Fix prettier * Fix parameter name * Linter fixes * Fix examples * Fix CI errors * Fix CI error * CI fixes * CI fixes * CI fixes' * CI fixes Co-authored-by: Somesh Chatterjee <soch@microsoft.com>

Notebooks swagger spec

7f34441

openapi-assignment-bot bot assigned erich-wang Jun 15, 2020

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 15, 2020

New line at the end of file

f82fed0

Remove new line at the end

e9231f7

chiragg4u reviewed Jun 20, 2020

View reviewed changes

ravbhatnagar reviewed Jun 23, 2020

View reviewed changes

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 23, 2020

PR feedback

1b285a8

erich-wang removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 27, 2020

Fix examples

18dd012

Fix CI errors

deccbaf

Fix CI error

ef17764

CI fixes

dcb4432

CI fixes

ab5da3d

CI fixes'

6c92c35

CI fixes

4c6bd6e

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required WaitForARMRevisit labels Jul 28, 2020

erich-wang approved these changes Jul 31, 2020

View reviewed changes

somu84 changed the title ~~[**WaitForARMFeedback**] Notebooks swagger spec~~ Notebooks swagger spec Jul 31, 2020

erich-wang merged commit cb01675 into Azure:master Aug 3, 2020

Notebooks swagger spec #9841

Notebooks swagger spec #9841

Conversation

somu84 commented Jun 15, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

openapi-pipeline-app bot commented Jun 15, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jun 15, 2020

azuresdkci commented Jun 15, 2020

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-java - Release

azure-pipelines bot commented Jun 16, 2020

azure-pipelines bot commented Jun 16, 2020

openapi-sdkautomation bot commented Jun 16, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

erich-wang commented Jun 17, 2020

chiragg4u commented Jun 20, 2020

chiragg4u Jun 20, 2020

Choose a reason for hiding this comment

chiragg4u Jun 20, 2020

Choose a reason for hiding this comment

somu84 Jun 22, 2020 • edited Loading

Choose a reason for hiding this comment

chiragg4u Jun 20, 2020

Choose a reason for hiding this comment

somu84 commented Jun 22, 2020 • edited Loading

somu84 commented Jun 22, 2020

ravbhatnagar left a comment

Choose a reason for hiding this comment

ravbhatnagar Jun 23, 2020

Choose a reason for hiding this comment

somu84 Jun 23, 2020

Choose a reason for hiding this comment

ravbhatnagar Jun 23, 2020

Choose a reason for hiding this comment

somu84 Jul 17, 2020

Choose a reason for hiding this comment

azure-pipelines bot commented Jun 23, 2020

azure-pipelines bot commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

azure-pipelines bot commented Jul 14, 2020

azure-pipelines bot commented Jul 14, 2020

azure-pipelines bot commented Jul 14, 2020

azure-pipelines bot commented Jul 14, 2020

erich-wang commented Jul 17, 2020

somu84 commented Jul 17, 2020

somu84 commented Jul 21, 2020

erich-wang commented Jul 22, 2020

somu84 commented Jul 27, 2020

ravbhatnagar commented Jul 28, 2020

erich-wang commented Jul 31, 2020

somu84 commented Jul 31, 2020

somu84 commented Jun 15, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 16, 2020 •

edited

Loading

somu84 Jun 22, 2020 •

edited

Loading

somu84 commented Jun 22, 2020 •

edited

Loading