Fix AAS Swagger Correctness v5 #12821

david-msft · 2021-02-03T22:48:30Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Merge Master

Merge latest master

Merge master

Merge Master

openapi-workflow-bot · 2021-02-03T22:48:32Z

Hi, @david-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-03T22:48:34Z

Swagger Validation Report

️❌BreakingChange: 10 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2016-05-16/analysisservices.json <---> new: stable/2016-05-16/analysisservices.json
- original: stable/2017-08-01/analysisservices.json <---> new: stable/2017-08-01/analysisservices.json

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'error' renamed or removed? New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1265:7 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1266:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'error' renamed or removed? New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1532:7 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1527:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'code' in response that was not found in the old version. New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1265:7 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1266:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'message' in response that was not found in the old version. New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1265:7 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1266:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'subCode' in response that was not found in the old version. New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1265:7 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1266:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'httpStatusCode' in response that was not found in the old version. New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1265:7 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1266:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'code' in response that was not found in the old version. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1532:7 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1527:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'message' in response that was not found in the old version. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1532:7 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1527:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'subCode' in response that was not found in the old version. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1532:7 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1527:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'httpStatusCode' in response that was not found in the old version. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1532:7 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1527:7

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- analysisservices/resource-manager/readme.md tag:package-2017-08
- analysisservices/resource-manager/readme.md tag:package-2016-05
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- analysisservices/resource-manager/readme.md tag:package-2017-08
- analysisservices/resource-manager/readme.md tag:package-2016-05

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 14 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

The following tags are being changed in this PR

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2017-08", "details":"The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2017-08", "details":"The schema 'Operation-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2017-08", "details":"The schema 'Operation-properties-serviceSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2017-08", "details":"The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2017-08", "details":"The schema 'ErrorDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2017-08", "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2017-08", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."
⚠️ PreCheck/SchemaMissingType	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2016-05", "details":"The schema 'OperationDetail-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2016-05", "details":"The schema 'OperationDetail-properties-serviceSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"analysisservices/resource-manager/readme.md", "tag":"package-2016-05", "details":"The schema 'OperationsErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-03T22:48:34Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b634944. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/analysisservices/resource-manager/readme.md

️✔️analysisservices [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b634944. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️analysisservices/mgmt/2017-08-01/analysisservices [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `GatewayListStatusLive.Status` has been changed from `Status` to `*int32`
info	[Changelog] - Type of `OperationStatus.Error` has been changed from `*ErrorResponse` to `*ErrorObject`
info	[Changelog] - Const `Live` has been removed
info	[Changelog] - Function `PossibleStatusValues` has been removed
info	[Changelog] - Field `Code` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `Message` of struct `ErrorResponse` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `GatewayError.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ErrorObject.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorObject`
info	[Changelog] - New struct `LogSpecifications`
info	[Changelog] - New struct `MetricDimensions`
info	[Changelog] - New struct `MetricSpecifications`
info	[Changelog] - New struct `OperationProperties`
info	[Changelog] - New struct `OperationPropertiesServiceSpecification`
info	[Changelog] - New field `ResourceType` in struct `SkuDetailsForExistingResource`
info	[Changelog] - New field `HTTPStatusCode` in struct `GatewayError`
info	[Changelog] - New field `TimeStamp` in struct `GatewayError`
info	[Changelog] - New field `SubCode` in struct `GatewayError`
info	[Changelog] - New field `ManagedMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerProperties`
info	[Changelog] - New field `ManagedMode` in struct `ServerProperties`
info	[Changelog] - New field `Sku` in struct `ServerProperties`
info	[Changelog] - New field `Description` in struct `OperationDisplay`
info	[Changelog] - New field `Origin` in struct `Operation`
info	[Changelog] - New field `Properties` in struct `Operation`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 25 additive change(s).
info	[Changelog]

️✔️analysisservices/mgmt/2017-07-14/analysisservices [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - New function `*OperationListResultPage.Next() error`
info	[Changelog] - New function `OperationsClient.ListComplete(context.Context) (OperationListResultIterator, error)`
info	[Changelog] - New function `NewOperationListResultIterator(OperationListResultPage) OperationListResultIterator`
info	[Changelog] - New function `OperationsClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `OperationListResultPage.NotDone() bool`
info	[Changelog] - New function `*OperationListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `OperationListResultIterator.Response() OperationListResult`
info	[Changelog] - New function `OperationListResultPage.Response() OperationListResult`
info	[Changelog] - New function `OperationListResultPage.Values() []OperationDetail`
info	[Changelog] - New function `OperationsClient.ListResponder(*http.Response) (OperationListResult, error)`
info	[Changelog] - New function `NewOperationListResultPage(OperationListResult, func(context.Context, OperationListResult) (OperationListResult, error)) OperationListResultPage`
info	[Changelog] - New function `NewOperationsClient(string) OperationsClient`
info	[Changelog] - New function `OperationListResultIterator.Value() OperationDetail`
info	[Changelog] - New function `OperationListResult.IsEmpty() bool`
info	[Changelog] - New function `*OperationListResultIterator.Next() error`
info	[Changelog] - New function `NewOperationsClientWithBaseURI(string, string) OperationsClient`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponseError`
info	[Changelog] - New struct `LogSpecifications`
info	[Changelog] - New struct `MetricDimensions`
info	[Changelog] - New struct `MetricSpecifications`
info	[Changelog] - New struct `OperationDetail`
info	[Changelog] - New struct `OperationDetailProperties`
info	[Changelog] - New struct `OperationDetailPropertiesServiceSpecification`
info	[Changelog] - New struct `OperationDisplay`
info	[Changelog] - New struct `OperationListResult`
info	[Changelog] - New struct `OperationListResultIterator`
info	[Changelog] - New struct `OperationListResultPage`
info	[Changelog] - New struct `OperationsClient`
info	[Changelog] - New struct `OperationsErrorResponse`
info	[Changelog] - New field `ManagedMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerProperties`
info	[Changelog] - New field `ManagedMode` in struct `ServerProperties`
info	[Changelog] - New field `ResourceType` in struct `SkuDetailsForExistingResource`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 57 additive change(s).
info	[Changelog]

️✔️analysisservices/mgmt/2016-05-16/analysisservices [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - New function `OperationListResultPage.Response() OperationListResult`
info	[Changelog] - New function `OperationListResultIterator.Response() OperationListResult`
info	[Changelog] - New function `OperationListResultPage.NotDone() bool`
info	[Changelog] - New function `OperationsClient.ListComplete(context.Context) (OperationListResultIterator, error)`
info	[Changelog] - New function `ErrorObject.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `OperationsClient.ListResponder(*http.Response) (OperationListResult, error)`
info	[Changelog] - New function `*OperationListResultPage.Next() error`
info	[Changelog] - New function `NewOperationsClientWithBaseURI(string, string) OperationsClient`
info	[Changelog] - New function `OperationDisplay.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `OperationListResultIterator.NotDone() bool`
info	[Changelog] - New function `*OperationListResultPage.NextWithContext(context.Context) error`
info	[Changelog] - New function `OperationsClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewOperationListResultIterator(OperationListResultPage) OperationListResultIterator`
info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NewOperationListResultPage(OperationListResult, func(context.Context, OperationListResult) (OperationListResult, error)) OperationListResultPage`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorObject`
info	[Changelog] - New struct `LogSpecifications`
info	[Changelog] - New struct `MetricDimensions`
info	[Changelog] - New struct `MetricSpecifications`
info	[Changelog] - New struct `OperationDetail`
info	[Changelog] - New struct `OperationDetailProperties`
info	[Changelog] - New struct `OperationDetailPropertiesServiceSpecification`
info	[Changelog] - New struct `OperationDisplay`
info	[Changelog] - New struct `OperationListResult`
info	[Changelog] - New struct `OperationListResultIterator`
info	[Changelog] - New struct `OperationListResultPage`
info	[Changelog] - New struct `OperationsClient`
info	[Changelog] - New struct `OperationsErrorResponse`
info	[Changelog] - New field `ResourceType` in struct `SkuDetailsForExistingResource`
info	[Changelog] - New field `Capacity` in struct `ResourceSku`
info	[Changelog] - New field `ManagedMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerMutableProperties`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog] - New field `ManagedMode` in struct `ServerProperties`
info	[Changelog] - New field `ServerMonitorMode` in struct `ServerProperties`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 58 additive change(s).
info	[Changelog]

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from b634944. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/analysisservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.AnalysisServices [View full logs] [Release SDK Changes]

cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(386,40): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(456,66): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(555,30): error CS0103: The name 'Status' does not exist in the current context [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(386,40): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(456,66): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(555,30): error CS0103: The name 'Status' does not exist in the current context [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b634944. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/analysisservices/resource-manager/readme.md

️✔️@azure/arm-analysisservices [View full logs] [Release SDK Changes]

azure-arm-analysisservices-2.3.2.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/analysisServicesManagementClient.js → ./dist/arm-analysisservices.js...
cmderr	[npmPack] created ./dist/arm-analysisservices.js in 310ms

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-03T22:58:00Z

Hi @david-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

openapi-workflow-bot · 2021-02-04T00:10:07Z

Hi @david-msft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-02-04T18:35:57Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

david-msft · 2021-02-04T18:45:06Z

Hi @chunyu3,
This PR is going to resolve S360 Swagger Correctness issues, https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=523a5c5c-7749-417d-8ce1-6eab5433338e and https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=d06c5dbd-8cde-4643-af17-3926a6f9e863. Please review when you have a chance. Thanks!

chunyu3 · 2021-02-05T04:49:35Z

@ArcturusZhang would you please review the 'break change for go'

ArcturusZhang · 2021-02-08T02:11:58Z

@chunyu3 The breaking changes in 2016-05-16 are intended by this PR. The other two are introduced by previous PRs.

* fix correctness * fix * fix prettier * add default value * no message * fix nit * use error object * Remove default

david-msft and others added 6 commits December 28, 2020 11:15

Merge pull request #1 from Azure/master

a5c1e62

Merge Master

Merge pull request #2 from Azure/master

4871a17

Merge Master

Merge pull request #3 from Azure/master

bfd34f2

Merge latest master

Merge pull request #4 from Azure/master

21fe6f8

Merge master

Merge pull request #5 from Azure/master

66282a6

Merge Master

fix correctness

4cdf9b3

openapi-sdkautomation bot mentioned this pull request Feb 3, 2021

[AutoPR @azure/arm-analysisservices] Fix AAS Swagger Correctness v5 AzureSDKAutomation/azure-sdk-for-js#3520

Closed

fix

362da6b

openapi-sdkautomation bot mentioned this pull request Feb 3, 2021

[AutoPR Microsoft.Azure.Management.AnalysisServices] Fix AAS Swagger Correctness v5 AzureSDKAutomation/azure-sdk-for-net#3126

Closed

fix prettier

67dcd8e

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Feb 3, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 3, 2021

openapi-sdkautomation bot mentioned this pull request Feb 3, 2021

[AutoPR analysisservices] Fix AAS Swagger Correctness v5 AzureSDKAutomation/azure-resource-manager-schemas#1598

Closed

add default value

2b54c34

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 4, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Feb 4, 2021

david-msft added 2 commits February 3, 2021 16:11

no message

6fdfa66

fix nit

2424e85

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 4, 2021

use error object

b70c1f2

openapi-workflow-bot bot added the FixS360 label Feb 4, 2021

david-msft marked this pull request as ready for review February 4, 2021 18:36

openapi-assignment-bot bot assigned chunyu3 Feb 4, 2021

Remove default

c108a09

chunyu3 requested a review from ArcturusZhang February 5, 2021 04:47

ArcturusZhang approved these changes Feb 8, 2021

View reviewed changes

chunyu3 added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 8, 2021

chunyu3 merged commit b634944 into Azure:master Feb 8, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Fix AAS Swagger Correctness v5 (Azure#12821)

1de4a07

* fix correctness * fix * fix prettier * add default value * no message * fix nit * use error object * Remove default

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix AAS Swagger Correctness v5 #12821

Fix AAS Swagger Correctness v5 #12821

david-msft commented Feb 3, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 3, 2021

openapi-pipeline-app bot commented Feb 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 3, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 3, 2021

openapi-workflow-bot bot commented Feb 4, 2021

openapi-workflow-bot bot commented Feb 4, 2021

david-msft commented Feb 4, 2021 •

edited

Loading

chunyu3 commented Feb 5, 2021

ArcturusZhang commented Feb 8, 2021

Fix AAS Swagger Correctness v5 #12821

Fix AAS Swagger Correctness v5 #12821

Conversation

david-msft commented Feb 3, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 3, 2021

openapi-pipeline-app bot commented Feb 3, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 3, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 3, 2021

openapi-workflow-bot bot commented Feb 4, 2021

openapi-workflow-bot bot commented Feb 4, 2021

david-msft commented Feb 4, 2021 • edited Loading

chunyu3 commented Feb 5, 2021

ArcturusZhang commented Feb 8, 2021

david-msft commented Feb 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 3, 2021 •

edited

Loading

david-msft commented Feb 4, 2021 •

edited

Loading