Merge Master #5
Merged
Merge Master #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System.Text.Json.JsonException : A property 'runEnd' defined as non-nullable but received as null from the service. This exception only happens in DEBUG builds of the library and would be ignored in the release build
Stack Trace:
at Azure.Core.JsonElementExtensions.ThrowNonNullablePropertyIsNull(JsonProperty property) in /Users/donblas/.nuget/packages/autorest.csharp/3.0.0-beta.20210105.3/content/Generator.Shared/JsonElementExtensions.cs:line 94
at Azure.Analytics.Synapse.Artifacts.Models.PipelineRun.DeserializePipelineRun(JsonElement element) in /Users/donblas/Programming/azure-sdk-for-net/sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/Generated/Models/PipelineRun.Serialization.cs:line 109
at Azure.Analytics.Synapse.Artifacts.Models.PipelineRunsQueryResponse.DeserializePipelineRunsQueryResponse(JsonElement element) in /Users/donblas/Programming/azure-sdk-for-net/sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/Generated/Models/PipelineRunsQueryResponse.Serialization.cs:line 27
at Azure.Analytics.Synapse.Artifacts.PipelineRunRestClient.QueryPipelineRunsByWorkspaceAsync(RunFilterParameters filterParameters, CancellationToken cancellationToken) in /Users/donblas/Programming/azure-sdk-for-net/sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/Generated/PipelineRunRestClient.cs:line 86
at Azure.Analytics.Synapse.Artifacts.PipelineRunClient.QueryPipelineRunsByWorkspaceAsync(RunFilterParameters filterParameters, CancellationToken cancellationToken) in /Users/donblas/Programming/azure-sdk-for-net/sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/Generated/PipelineRunClient.cs:line 48
…table/2020-11-01 (#12444) * add fields for 20201101 * fix waf json * fix waf json * minor fix * prettier fix for waf json * minor fix
Co-authored-by: Jeremy Hurren <jehurren@microsoft.com>
* top level name can be 64 char long * remove ssoContext, startMenuItems friendly name and fix operation example * readme fixes
* correct swagger path * fix readme * fix ref
…rsion stable/2021-01-11 (#12125) * Adds base for updating Microsoft.HealthcareApis from version stable/2020-03-30 to version 2021-01-11 * Updates readme * Updates API version in new specs and examples * Add new api spec * Fix tests. * Add description for systemData * Remove common type change * Prettier spec * Change definition name * Modify list result
* Add networkProperties and clusterId * Add display.description and properties of operation. Fix DeletionOperationResponse linting error Add privateIPAddress in ConnectivityEndpoints and ApplicationGetEndpoints * Fix model validation error: update example Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
…ion stable/2021-01-01 (#12337) * Adds base for updating Microsoft.MixedReality from version preview/2020-04-06-preview to version 2021-01-01 * Updates readme * Updates API version in new specs and examples * update proxy and remote rendering * add description * add security definitions * revert security definitions * add systemdata * run prettier * move systemdata to remote-rendering.json * switch to use v1 types * add spatial anchors accounts * add x-ms-secret to dev keys * replace values with *** * suppress secret_property
…2518) Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
* set default value for vnet name * update
…n stable/2017-06-01 (#11937) * added default error response where missing and fixed camel case action names * removed readonly properties from examples * removed more readonly properties from examples * remove hard-coded product name from swagger action * added enable remote management action * ran npm prettier on new jsong files * moved remote management action to registrations
* Purview update network acls and patch API * Update prettier
…stable/2018-09-01 (#12314) * copied metricBaselines from 2019 * Added 2018 api version for metricBaselines * Added example file of new api * fixed prettier * fixed api version * added object type * fixed api version and semantic error * added metricBaselines to readme * fixed prettier for 2019 version * removed metricBaselines 2018 from package * added back the reference to 2018 * removed reference * added reference * Trying to edit description * Trying to fix linting error * reverted description * changed description due to validation error * trying to reference to api version from types * added reference to 2018-09
* update lint rule documentation for R4009&R2005 * add r4031 * improve * Update openapi-authoring-automated-guidelines.md * improve R4005 * up * up * up * up Co-authored-by: jianye xi <jianyxi@microsoft.com>
* Added readme.python.md for multi API support
* Data-plane specs added for Library Apis * Swagger specs added for Append Library Api * Resolved reviewer comments in data plane library apis * Append API is changed to have application/octet-stream content * API schema changed for create and append api Co-authored-by: Navneet Singh <navsi@microsoft.com>
* [communication] Add cloud property to Teams identifier * rename to CommunicationCloudEnvironment * rename to CommunicationCloudEnvironmentModel * prettier and spelling fix
* add missing properties and response code * remove default * add default * Revert "add default" This reverts commit 4977c0c. * fix prettier * add readonly field
- I've corrected the format of the "accountId" to be a "uuid" as it should be. This is not a breaking change made by the API. This is a correction to the spec file to more accurately reflect what is expected. - I've also moved the examples where they should be. Co-authored-by: Craig Treasure <crtreasu@microsoft.com>
* Fix minor issues in policy exemptions * Address some issues regarding SDK gen * Addessed the comment * Fixed go SDK generation error
…n preview/2020-06-01-preview (#12622) * init * fix name * fix property * array format * fix lsit * fix response * name * discription * modify description * revert new api Co-authored-by: Teng Pan <tepa@microsoft.com>
* FIxing Privatestore ,Offer properties and examples * Fixing properties types * Fixing camel cases * Add Idempotence to custom-words.txt * prettier check changes * adding description to isGov * resolve conflicts * Fix updateSuppressedDueIdempotence type * FIx swagger validation issues * Fix json * Fix indentation conflicts * Fix corruption * Fix validations * FIx marketplace swagger * new notifications apis * prettier check run * Fix spell check * fix missing definitions on json file and and new json file to readme file * FIx errors * Fix missing curly bracket * prettier check * Fixing errors * Fix swagger errors * Fix more errors * Fix errors * adding all existing apis to new api version * missing parameters * add support to systemData * Revert "add support to systemData" This reverts commit f49484c. * Revert "missing parameters" This reverts commit 9b96ce9. * Revert "adding all existing apis to new api version" This reverts commit 6528d5f. * support multiple version * remove duplicated operation path * change swagger to support resource pattern * fix tests * fix typo * package lock * prettier * fix sdk for .net * Fix documetation per ARM RPC * npm run prettier * fix tests * fix tests * Fix tests * Fix ARM comments * Revert "package lock" This reverts commit a732a0a. * delete WithdrawPlan.json * Re-add WithdrawPlan.json * fix tests * fix tests * Fix tests * Fix tests * fix tests * remove npm-debug.log * Fix comments * change to "format": "date-time" * Fix tests
…and examples (#12522) * clean up and add more descriptions * add missing location * fix small typo * update more descriptions * remove restorables * add missing descriptions * fix resource * pretty * unflatten * remove flatten * remove flatten
* Initial commit * Fix model validation * Fix typo
* add 2020-10-01-only to python.md * fix
* update python track2 config for redisenterprise * remove old namespace * fix * fix
…12488) * fix issue in 2020-02-01 * fix issue in 2020-05-01 * fix model validation * fix prettier * revert some removal of x-ms-parameter-location
* OperationalInsights: Changing property mutibality to default. * Cluster identity description change. Co-authored-by: Dudi Likvornik <dulikvor@microsoft.com>
…dd version preview/2.0 (#12792) * Update render.json * Update render.json updates
* Add labeling jobs operations in spec and examples * Fix labeling job id * move to jobs.json following codeJob pattern * fix eol * Fix readme.md * Fix spec failures * fix spec * Fix deleteLabelingJob * Fix status message list * fix * Fix prettier * handle polymorphic objects * Fix discriminator * Fix polyphorphic def * Fix * Fix * fix * fix * Fix lintdiff error * Fix conflict * Fix LintDiff * Fix LintDiff * Remove id and continuation token. Address comments * Fix LintDiff * Fix * Update azuresourceschema.md * Fix LintDiff * Fix LintDiff * Fix LintDiff
…2397) * Remove scope from marketplace registration definitions operations * Swagger fixes * Changed operation ids * Validation fixes * Unique x-ms-example names * Name fix for examples * Removed sub from example responses * Added empty eligibleAuths to 2020-02-01-preview MRD examples
* Update scheduledQueryRule_API.json Fixed Error contract to fit the real structure * Update createOrUpdateScheduledQueryRules.json Removed readonly properties from example parameters * Update scheduledQueryRule_API.json Added property "displayName" to the structure * Fix to item ; https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=A596EA9C-C8E9-4A72-90FE-4689DFCBA3F6 Fix to item ; https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=A596EA9C-C8E9-4A72-90FE-4689DFCBA3F6 * added display name to the new API version * Fixed descriptions * Added OverrideQueryTimeRange to Swagger on new API version * returned enabled property back to bool * Update scheduledQueryRule_API.json Added missing enum values to ConditionalOperator property * Update scheduledQueryRule_API.json Aligned RP name to pascal format * revert lindent correvction to avoid breaking chnage * run prettier and fixed SubscriptionIdParameter * revert subscripton id to the former description * aligned diagnosticSettings with master * removed locaiton from example * returned location to example * supress false alaram OBJECT_ADDITIONAL_PROPERTIES error * fix suppression * fix merge conflict * removed where clause * added properties isLegacyLogAnalyticsRule, createdWithApiVersion to both api versions
* missing operations * swagger linter issues * suppression * add count property * fix swagger model issues
* Fix GetAmlCompute examples for isolatedNetwork * add computeInstanceAuthorizationType to 20200801 * add OsType to amlcompute 20200801 * give default ostype for amlcompute * Update nodeIdleTimeBeforeScaleDown description 20200801 * add "auto" to SslConfiguration enum * matching identiity.type enum order of future * agentvmsize typo fixed * add setupScripts to computeInstance 09-01 * add format to agentCount 20200801 * mark listnodes as pageable Co-authored-by: jopet@microsoft.com <jopet@microsoft.com>
* Swagger correctness operations API * Swagger correctness: Fix readonly properties * Swagger correctness: Fix readonly properties * Correcting readonly fields
* add auto rest markup, remove malformed swagger examples, factor out paramaters * fixes typos * add readOnly markup and mark session_list sessions property as required * removes readonly flag for required params * fixes comment for session id * removes host, schemas and basepath since generated code would contain them. clarify SAS not being filled out in response bodies * add endpoint
* avoid python ta config duplication * remove all python blocks from main readme
* test * updating readme for python under translatortext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.