MFA MUA DPP swagger changes #13081
Merged
MFA MUA DPP swagger changes #13081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @deymadhumanti Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"The schema 'AzureBackupRecoveryPointResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"The schema 'BackupInstanceResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"The schema 'BackupVaultResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"The schema 'BaseBackupPolicyResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"The schema 'Error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"The schema 'JobExtendedInfo-additionalDetails' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"The schema 'JobSubTask-additionalDetails' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"dataprotection/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @deymadhumanti, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
| } | ||
| } | ||
| }, | ||
| "DppTrackedResourceList": { |
There was a problem hiding this comment.
Please refer from the main json instead.
weidongxu-microsoft
approved these changes
Feb 23, 2021
ChenTanyi
pushed a commit
that referenced
this pull request
Feb 26, 2021
* New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Microsoft.data protection (#12814) * moving changes from Private repo * changes for autorest vqalidation err * fix delete response * fixing lint and model errors * exposureControlledFeatures fixes * prettier fixes * fixing spell check issues * adding backuptype in custom-words * PolicyParameters related changes for Disk Backup * fixing PR comments * description changes * changes for preview to stable folder * changes for retention in monitoring * changes for stable in readme * fixing checklist gate issues * changes for systemdata in dppresource Co-authored-by: sumitmal <32121310+sumitmal@users.noreply.github.com> Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: vityagi <vityagi@microsoft.com> * MFA MUA DPP swagger changes (#13081) * MFA MUA DPP swagger changes * Resolving PR comments Co-authored-by: Madhumanti Dey <madhude@microsoft.com> * Swagger changes for VaultGuardResource Object (#13116) * MFA MUA DPP swagger changes * Resolving PR comments * MFA MUA dpp swagger changes * Fixed preetierCheck failures * Fixed Avocado failures * Fixed LintDiff warning * resolved PR comments * GO SDK fix * Go SDK fix * Go SDK fix * preview related changes * Go SDK fix * resolved PR comments Co-authored-by: Madhumanti Dey <madhude@microsoft.com> * changes for preview DPP version * fix for credscan SAS Co-authored-by: sumitmal2711 <58544969+sumitmal2711@users.noreply.github.com> Co-authored-by: sumitmal <32121310+sumitmal@users.noreply.github.com> Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: vityagi <vityagi@microsoft.com> Co-authored-by: deymadhumanti <58032062+deymadhumanti@users.noreply.github.com> Co-authored-by: Madhumanti Dey <madhude@microsoft.com>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Microsoft.data protection (Azure#12814) * moving changes from Private repo * changes for autorest vqalidation err * fix delete response * fixing lint and model errors * exposureControlledFeatures fixes * prettier fixes * fixing spell check issues * adding backuptype in custom-words * PolicyParameters related changes for Disk Backup * fixing PR comments * description changes * changes for preview to stable folder * changes for retention in monitoring * changes for stable in readme * fixing checklist gate issues * changes for systemdata in dppresource Co-authored-by: sumitmal <32121310+sumitmal@users.noreply.github.com> Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: vityagi <vityagi@microsoft.com> * MFA MUA DPP swagger changes (Azure#13081) * MFA MUA DPP swagger changes * Resolving PR comments Co-authored-by: Madhumanti Dey <madhude@microsoft.com> * Swagger changes for VaultGuardResource Object (Azure#13116) * MFA MUA DPP swagger changes * Resolving PR comments * MFA MUA dpp swagger changes * Fixed preetierCheck failures * Fixed Avocado failures * Fixed LintDiff warning * resolved PR comments * GO SDK fix * Go SDK fix * Go SDK fix * preview related changes * Go SDK fix * resolved PR comments Co-authored-by: Madhumanti Dey <madhude@microsoft.com> * changes for preview DPP version * fix for credscan SAS Co-authored-by: sumitmal2711 <58544969+sumitmal2711@users.noreply.github.com> Co-authored-by: sumitmal <32121310+sumitmal@users.noreply.github.com> Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: vityagi <vityagi@microsoft.com> Co-authored-by: deymadhumanti <58032062+deymadhumanti@users.noreply.github.com> Co-authored-by: Madhumanti Dey <madhude@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.
No new changes are there. copied the content of 2021-01-01 folder to 2021-02-01-preview. Will make the MFA MUA changes on top of this