Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #13378

Merged
merged 3 commits into from
Mar 12, 2021
Merged

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #13378

merged 3 commits into from
Mar 12, 2021

Conversation

olsaal-msft
Copy link
Contributor

@olsaal-msft olsaal-msft commented Mar 11, 2021 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@olsaal-msft olsaal-msft requested a review from kjeur as a code owner March 11, 2021 00:36
@openapi-workflow-bot
Copy link

Hi, @olsaal-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 11, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

    Rule Message
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'forecastSpend' that was not found in the old version.
    New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3898:7
    Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3898:7
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 54 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'MeterDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'UsageDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'LegacyUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'ModernUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'ReservationSummariesListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'ReservationSummaryProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'ReservationDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'ReservationDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'ReservationRecommendationDetailsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"consumption/resource-manager/readme.md",
    "tag":"package-2019-10",
    "details":"The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 11, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 99ec48d. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_ratio
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_group
info	[Changelog]   - Model ReservationDetail has a new parameter kind
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Model Budget has a new parameter filter
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model Notification has a new parameter threshold_type
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter purchased_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter total_reserved_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter kind
info	[Changelog]   - Model ReservationSummary has a new parameter remaining_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter utilized_percentage
info	[Changelog]   - Model ReservationSummary has a new parameter used_quantity
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Added operation ReservationRecommendationsOperations.list
info	[Changelog]   - Added operation ReservationsDetailsOperations.list
info	[Changelog]   - Added operation ReservationsSummariesOperations.list
info	[Changelog]   - Added operation ChargesOperations.list
info	[Changelog]   - Added operation group ReservationTransactionsOperations
info	[Changelog]   - Added operation group LotsOperations
info	[Changelog]   - Added operation group EventsOperations
info	[Changelog]   - Added operation group CreditsOperations
info	[Changelog]   - Added operation group ReservationRecommendationDetailsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model Budget no longer has parameter filters
info	[Changelog]   - Removed operation UsageDetailsOperations.download
info	[Changelog]   - Model ReservationRecommendation has a new signature
info	[Changelog]   - Model ChargeSummary has a new signature
info	[Changelog]   - Model UsageDetail has a new signature
info	[Changelog]   - Removed operation ChargesOperations.list_by_scope
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 99ec48d. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
    • ️✔️@azure/arm-consumption [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
cmderr	[npmPack] created ./dist/arm-consumption.js in 545ms
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 99ec48d. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model ChargeSummary has a new parameter etag
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model EventSummary has a new parameter etag
info	[Changelog]   - Model LotSummary has a new parameter etag
info	[Changelog]   - Model UsageDetail has a new parameter etag
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
info	[Changelog]   - Model CreditSummary has a new parameter etag
info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Added operation ReservationRecommendationDetailsOperations.get
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 99ec48d. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
    • ️✔️consumption [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] npm WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 99ec48d. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-03-12 05:21:05 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-consumption"
cmderr	[generate.py] 2021-03-12 05:21:05 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-03-12 05:21:05 INFO autorest --version=3.1.0 --use=@autorest/java@4.0.19 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[generate.py] 2021-03-12 05:21:52 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-03-12 05:21:52 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-03-12 05:21:52 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
cmderr	[generate.py] 2021-03-12 05:21:52 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-03-12 05:21:52 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-03-12 05:21:52 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-consumption [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-03-12 05:25:00 DEBUG Got artifact_id: azure-resourcemanager-consumption
cmderr	[Inst] 2021-03-12 05:25:00 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-03-12 05:25:00 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-12 05:25:00 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-12 05:25:00 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13378/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.1.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 99ec48d. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Consumption [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 99ec48d. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️consumption/mgmt/2019-10-01/consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New field `AdditionalInfo` in struct `MarketplaceProperties`
info	[Changelog] - New field `PayGPrice` in struct `ModernUsageDetailProperties`
info	[Changelog] - New field `Etag` in struct `ModernReservationRecommendation`
info	[Changelog] - New field `Download` in struct `PriceSheetModel`
info	[Changelog] - New field `Etag` in struct `ChargeSummary`
info	[Changelog] - New field `Etag` in struct `LegacyUsageDetail`
info	[Changelog] - New field `Etag` in struct `ManagementGroupAggregatedCostResult`
info	[Changelog] - New field `Value` in struct `Tag`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 41 additive change(s).
info	[Changelog]
    • ️✔️consumption/mgmt/2019-01-01/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-10-01/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-08-31/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-06-30/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-05-31/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-03-31/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-01-31/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2017-11-30/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    This was referenced Mar 11, 2021
    Closed
    Closed
    This was referenced Mar 11, 2021
    Closed
    Closed
    This was referenced Mar 11, 2021
    Closed
    Closed
    @openapi-workflow-bot
    Copy link

    Hi @olsaal-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @olsaal-msft
    Copy link
    Contributor Author

    Submitted breaking change review - https://msazure.visualstudio.com/One/_workitems/edit/9513514

    This was referenced Mar 12, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @Lira-tron Lira-tron mentioned this pull request Mar 15, 2021
    Merged
    25 tasks
    PhoenixHe-NV pushed a commit that referenced this pull request Mar 16, 2021
    @Lira-tron
    Adding fixes made in 2019-10-01 to 2019-11-01 (#13414)
    7e76220 
    The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
#12777
#12555
#13039
#13097
#12822
#13280
#12942
#13248
#13378

This PR is to add those corrections to 2019-11-01 version
    openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 16, 2021
    CodeGen from PR 13414 in Azure/azure-rest-api-specs
    020281f 
    Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414)

The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
Azure/azure-rest-api-specs#12777
Azure/azure-rest-api-specs#12555
Azure/azure-rest-api-specs#13039
Azure/azure-rest-api-specs#13097
Azure/azure-rest-api-specs#12822
Azure/azure-rest-api-specs#13280
Azure/azure-rest-api-specs#12942
Azure/azure-rest-api-specs#13248
Azure/azure-rest-api-specs#13378

This PR is to add those corrections to 2019-11-01 version
    openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-resource-manager-schemas that referenced this pull request Mar 16, 2021
    CodeGen from PR 13414 in Azure/azure-rest-api-specs
    dda89e2 
    Adding fixes made in 2019-10-01 to 2019-11-01 (#13414)

The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
Azure/azure-rest-api-specs#12777
Azure/azure-rest-api-specs#12555
Azure/azure-rest-api-specs#13039
Azure/azure-rest-api-specs#13097
Azure/azure-rest-api-specs#12822
Azure/azure-rest-api-specs#13280
Azure/azure-rest-api-specs#12942
Azure/azure-rest-api-specs#13248
Azure/azure-rest-api-specs#13378

This PR is to add those corrections to 2019-11-01 version
    openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 16, 2021
    CodeGen from PR 13414 in Azure/azure-rest-api-specs
    c69747d 
    Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414)

The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
Azure/azure-rest-api-specs#12777
Azure/azure-rest-api-specs#12555
Azure/azure-rest-api-specs#13039
Azure/azure-rest-api-specs#13097
Azure/azure-rest-api-specs#12822
Azure/azure-rest-api-specs#13280
Azure/azure-rest-api-specs#12942
Azure/azure-rest-api-specs#13248
Azure/azure-rest-api-specs#13378

This PR is to add those corrections to 2019-11-01 version
    openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 16, 2021
    CodeGen from PR 13414 in Azure/azure-rest-api-specs
    20b1895 
    Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414)

The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
Azure/azure-rest-api-specs#12777
Azure/azure-rest-api-specs#12555
Azure/azure-rest-api-specs#13039
Azure/azure-rest-api-specs#13097
Azure/azure-rest-api-specs#12822
Azure/azure-rest-api-specs#13280
Azure/azure-rest-api-specs#12942
Azure/azure-rest-api-specs#13248
Azure/azure-rest-api-specs#13378

This PR is to add those corrections to 2019-11-01 version
    openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Mar 16, 2021
    CodeGen from PR 13414 in Azure/azure-rest-api-specs
    3e75537 
    Adding fixes made in 2019-10-01 to 2019-11-01 (#13414)

The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
Azure/azure-rest-api-specs#12777
Azure/azure-rest-api-specs#12555
Azure/azure-rest-api-specs#13039
Azure/azure-rest-api-specs#13097
Azure/azure-rest-api-specs#12822
Azure/azure-rest-api-specs#13280
Azure/azure-rest-api-specs#12942
Azure/azure-rest-api-specs#13248
Azure/azure-rest-api-specs#13378

This PR is to add those corrections to 2019-11-01 version
    MirzaSikander pushed a commit to MirzaSikander/azure-rest-api-specs that referenced this pull request Mar 22, 2021
    @olsaal-msft @MirzaSikander
    [Hub Generated] Review request for Microsoft.Consumption to add versi…
    53cbd0f 
    …on stable/2019-10-01 (Azure#13378)

* Added swagger updates for the optional forecastSpend JSON field in Budget API

* Review feedback

* Internal review update
    MirzaSikander pushed a commit to MirzaSikander/azure-rest-api-specs that referenced this pull request Mar 22, 2021
    @Lira-tron @MirzaSikander
    Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414)
    d3db2d3 
    The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
Azure#12777
Azure#12555
Azure#13039
Azure#13097
Azure#12822
Azure#13280
Azure#12942
Azure#13248
Azure#13378

This PR is to add those corrections to 2019-11-01 version
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @olsaal-msft @mkarmark
    [Hub Generated] Review request for Microsoft.Consumption to add versi…
    2982bb4 
    …on stable/2019-10-01 (Azure#13378)

* Added swagger updates for the optional forecastSpend JSON field in Budget API

* Review feedback

* Internal review update
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @Lira-tron @mkarmark
    Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414)
    aa02234 
    The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
Azure#12777
Azure#12555
Azure#13039
Azure#13097
Azure#12822
Azure#13280
Azure#12942
Azure#13248
Azure#13378

This PR is to add those corrections to 2019-11-01 version
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    @ChenTanyi ChenTanyi ChenTanyi approved these changes

    @kjeur kjeur Awaiting requested review from kjeur kjeur is a code owner

    Assignees

    @ChenTanyi ChenTanyi

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @olsaal-msft @JeffreyRichter @ChenTanyi