Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisualStudioCodeCredential should throw CredentialUnavailableException for adfs tenants #13414

Closed
g2vinay opened this issue Aug 28, 2020 · 0 comments · Fixed by #13556
Closed

VisualStudioCodeCredential should throw CredentialUnavailableException for adfs tenants #13414

g2vinay opened this issue Aug 28, 2020 · 0 comments · Fixed by #13556
Assignees
@chlowell
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Milestone
[2020] September

Comments

@g2vinay
Copy link
Member

g2vinay commented Aug 28, 2020

VS Code IDE does not support ADFS authorities
The respective credential should throw Credential Unavailable Exception to avoid breaking DAC auth flow.

Throw CredentialUnavailableException if tenantId is 'adfs' in VsCodeCredential.
@g2vinay g2vinay added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Aug 28, 2020
@g2vinay g2vinay added this to the [2020] September milestone Aug 28, 2020
@chlowell chlowell changed the title Visual Studio credential should throw Credential Unavailable Exception for adfs tenants VisualStudioCodeCredential should throw CredentialUnavailableException for adfs tenants Aug 28, 2020
@g2vinay g2vinay added the blocking-release Blocks release label Aug 29, 2020
@chlowell chlowell mentioned this issue Sep 3, 2020
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Mar 16, 2021
CodeGen from PR 13414 in Azure/azure-rest-api-specs
c69747d 
Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414)

The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
Azure/azure-rest-api-specs#12777
Azure/azure-rest-api-specs#12555
Azure/azure-rest-api-specs#13039
Azure/azure-rest-api-specs#13097
Azure/azure-rest-api-specs#12822
Azure/azure-rest-api-specs#13280
Azure/azure-rest-api-specs#12942
Azure/azure-rest-api-specs#13248
Azure/azure-rest-api-specs#13378

This PR is to add those corrections to 2019-11-01 version
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Mar 16, 2021
CodeGen from PR 13414 in Azure/azure-rest-api-specs
20b1895 
Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414)

The PR for adding new version 2019-11-01 took longer than expected to be
approved, so some fixes made in 10-01 were not included in 2019-11-01
version.

The missing changes were the following PRs:
Azure/azure-rest-api-specs#12777
Azure/azure-rest-api-specs#12555
Azure/azure-rest-api-specs#13039
Azure/azure-rest-api-specs#13097
Azure/azure-rest-api-specs#12822
Azure/azure-rest-api-specs#13280
Azure/azure-rest-api-specs#12942
Azure/azure-rest-api-specs#13248
Azure/azure-rest-api-specs#13378

This PR is to add those corrections to 2019-11-01 version
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chlowell chlowell

Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2020] September
2 participants
@g2vinay @chlowell