Fix swagger correctness: secrets were wrongfully marked as write-only #17228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @juniwang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.SignalRService/stable/2021-10-01/webpubsub.json#L2332 |
|
| Based on the response model schema, operation 'SignalR_ListSkus' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SignalRService/stable/2021-10-01/signalr.json#L1071 |
|
| Based on the response model schema, operation 'WebPubSub_ListSkus' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SignalRService/stable/2021-10-01/webpubsub.json#L1288 |
|
| The resource 'PrivateLinkResource' does not have get operation, please add it. Location: Microsoft.SignalRService/stable/2021-10-01/signalr.json#L1499 |
|
| The resource 'PrivateLinkResource' does not have get operation, please add it. Location: Microsoft.SignalRService/stable/2021-10-01/webpubsub.json#L1761 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=271259&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️✔️azure-sdk-for-go-track2 - armsignalr - 0.1.1️✔️azure-sdk-for-go-track2 - armwebpubsub - 0.1.1️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-signalr - 1.0.0️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-webpubsub - 1.0.0️✔️azure-sdk-for-go - signalr/mgmt/2021-10-01/signalr - v61.0.0️✔️azure-sdk-for-go - signalr/mgmt/2020-05-01/signalr - v61.0.0️✔️azure-sdk-for-go - signalr/mgmt/2018-10-01/signalr - v61.0.0️✔️azure-sdk-for-go - preview/signalr/mgmt/2021-09-01-preview/signalr - v61.0.0️✔️azure-sdk-for-go - preview/signalr/mgmt/2021-06-01-preview/signalr - v61.0.0️✔️azure-sdk-for-go - preview/signalr/mgmt/2021-04-01-preview/signalr - v61.0.0️✔️azure-sdk-for-go - preview/signalr/mgmt/2020-07-01-preview/signalr - v61.0.0️✔️azure-sdk-for-go - preview/signalr/mgmt/2018-03-01-preview/signalr - v61.0.0️✔️azure-sdk-for-go - webpubsub/mgmt/2021-10-01/webpubsub - v61.0.0️✔️azure-sdk-for-go - preview/webpubsub/mgmt/2021-09-01-preview/webpubsub - v61.0.0️✔️azure-sdk-for-go - preview/webpubsub/mgmt/2021-06-01-preview/webpubsub - v61.0.0️✔️azure-sdk-for-go - preview/webpubsub/mgmt/2021-04-01-preview/webpubsub - v61.0.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-6.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/signalr/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/webpubsub/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.SignalR [View full logs] [Release SDK Changes]️✔️Microsoft.Azure.Management.WebPubSub [View full logs] [Release SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.1> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@8.3.1` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-signalr [View full logs] [Release SDK Changes]info [Changelog]
️✔️track2_azure-mgmt-webpubsub [View full logs] [Release SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2022-01-14 03:17:42 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-signalr;1.0.0-beta.3;1.0.0-beta.4" cmderr [generate.py] 2022-01-14 03:17:42 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.4" cmderr [generate.py] 2022-01-14 03:17:42 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/signalr/azure-resourcemanager-signalr --java.namespace=com.azure.resourcemanager.signalr --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/signalr/resource-manager/readme.md cmderr [generate.py] 2022-01-14 03:18:14 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-signalr cmderr [generate.py] 2022-01-14 03:18:14 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2022-01-14 03:18:14 INFO [POM][Skip] pom already has module azure-resourcemanager-signalr cmderr [generate.py] 2022-01-14 03:18:14 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2022-01-14 03:18:14 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2022-01-14 03:18:14 INFO [POM][Skip] pom already has module sdk/signalr cmderr [generate.py] 2022-01-14 03:18:14 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-signalr [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-signalr-1.0.0-beta.4.jar
- azure-resourcemanager-signalr-1.0.0-beta.4-sources.jar
cmderr [Inst] 2022-01-14 03:19:26 DEBUG Got artifact_id: azure-resourcemanager-signalr cmderr [Inst] 2022-01-14 03:19:26 DEBUG Got artifact: pom.xml cmderr [Inst] 2022-01-14 03:19:26 DEBUG Got artifact: azure-resourcemanager-signalr-1.0.0-beta.4.jar cmderr [Inst] 2022-01-14 03:19:26 DEBUG Match jar package: azure-resourcemanager-signalr-1.0.0-beta.4.jar cmderr [Inst] 2022-01-14 03:19:26 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17228/azure-sdk-for-java/azure-resourcemanager-signalr/azure-resourcemanager-signalr-1.0.0-beta.4.jar\" -o azure-resourcemanager-signalr-1.0.0-beta.4.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-signalr -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-signalr-1.0.0-beta.4.jar -Dpackaging=jar -DgeneratePom=true ```"}️✔️azure-resourcemanager-webpubsub [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-webpubsub-1.0.0-beta.3-sources.jar
- azure-resourcemanager-webpubsub-1.0.0-beta.3.jar
cmderr [Inst] 2022-01-14 03:20:19 DEBUG Got artifact_id: azure-resourcemanager-webpubsub cmderr [Inst] 2022-01-14 03:20:19 DEBUG Got artifact: pom.xml cmderr [Inst] 2022-01-14 03:20:19 DEBUG Got artifact: azure-resourcemanager-webpubsub-1.0.0-beta.3-sources.jar cmderr [Inst] 2022-01-14 03:20:19 DEBUG Got artifact: azure-resourcemanager-webpubsub-1.0.0-beta.3.jar cmderr [Inst] 2022-01-14 03:20:19 DEBUG Match jar package: azure-resourcemanager-webpubsub-1.0.0-beta.3.jar cmderr [Inst] 2022-01-14 03:20:19 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17228/azure-sdk-for-java/azure-resourcemanager-webpubsub/azure-resourcemanager-webpubsub-1.0.0-beta.3.jar\" -o azure-resourcemanager-webpubsub-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-webpubsub -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-webpubsub-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true ```"}
️⚠️ azure-sdk-for-js warning [Detail]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json cmderr [automation_init.sh] read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist cmderr [automation_init.sh] deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. cmderr [automation_init.sh] @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js cmderr [automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file. cmderr [automation_init.sh] @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself. warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️track2_@azure/arm-signalr [View full logs] [Release SDK Changes]info [Changelog] error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️✔️track2_@azure/arm-webpubsub [View full logs] [Release SDK Changes]info [Changelog] error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️signalr/mgmt/2021-10-01/signalr [View full logs] [Release SDK Changes]info [Changelog] This is a new package info [Changelog]
️✔️signalr/mgmt/2020-05-01/signalr [View full logs]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `Trace` info [Changelog] - New function `CreateOrUpdateProperties.MarshalJSON() ([]byte, error)` info [Changelog] - New function `ResourceSku.MarshalJSON() ([]byte, error)` info [Changelog] info [Changelog] Total 0 breaking change(s), 3 additive change(s).
️✔️signalr/mgmt/2018-10-01/signalr [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/signalr/mgmt/2021-09-01-preview/signalr [View full logs]info [Changelog] This is a new package info [Changelog]
️✔️preview/signalr/mgmt/2021-06-01-preview/signalr [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/signalr/mgmt/2021-04-01-preview/signalr [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/signalr/mgmt/2020-07-01-preview/signalr [View full logs]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New function `ResourceSku.MarshalJSON() ([]byte, error)` info [Changelog] info [Changelog] Total 0 breaking change(s), 1 additive change(s).
️✔️preview/signalr/mgmt/2018-03-01-preview/signalr [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️webpubsub/mgmt/2021-10-01/webpubsub [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/webpubsub/mgmt/2021-09-01-preview/webpubsub [View full logs]info [Changelog] This is a new package info [Changelog]
️✔️preview/webpubsub/mgmt/2021-06-01-preview/webpubsub [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️preview/webpubsub/mgmt/2021-04-01-preview/webpubsub [View full logs]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 60 items here, please refer to log for details.
️✔️armsignalr [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - New struct `PrivateLinkResourcesClient` info [Changelog] - New struct `PrivateLinkResourcesClientListOptions` info [Changelog] - New struct `PrivateLinkResourcesClientListPager` info [Changelog] - New struct `PrivateLinkResourcesClientListResponse` info [Changelog] - New struct `PrivateLinkResourcesClientListResult` info [Changelog] - New struct `Properties` info [Changelog] - New struct `ResourceList` info [Changelog] - New struct `ResourceModel` info [Changelog] - New struct `SharedPrivateLinkResourcesClient` info [Changelog] - New struct `SharedPrivateLinkResourcesClientBeginCreateOrUpdateOptions` info [Changelog] - New struct `SharedPrivateLinkResourcesClientBeginDeleteOptions` info [Changelog] - New struct `SharedPrivateLinkResourcesClientCreateOrUpdatePoller` info [Changelog] - New struct `SharedPrivateLinkResourcesClientCreateOrUpdatePollerResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientCreateOrUpdateResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientCreateOrUpdateResult` info [Changelog] - New struct `SharedPrivateLinkResourcesClientDeletePoller` info [Changelog] - New struct `SharedPrivateLinkResourcesClientDeletePollerResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientDeleteResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientGetOptions` info [Changelog] - New struct `SharedPrivateLinkResourcesClientGetResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientGetResult` info [Changelog] - New struct `SharedPrivateLinkResourcesClientListOptions` info [Changelog] - New struct `SharedPrivateLinkResourcesClientListPager` info [Changelog] - New struct `SharedPrivateLinkResourcesClientListResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientListResult` info [Changelog] - New struct `TLSSettings` info [Changelog] - New struct `Usage` info [Changelog] - New struct `UsageList` info [Changelog] - New struct `UsageName` info [Changelog] - New struct `UsagesClientListOptions` info [Changelog] - New struct `UsagesClientListPager` info [Changelog] - New struct `UsagesClientListResponse` info [Changelog] - New struct `UsagesClientListResult` info [Changelog] - New field `ID` in struct `TrackedResource` info [Changelog] - New field `Name` in struct `TrackedResource` info [Changelog] - New field `Type` in struct `TrackedResource` info [Changelog] - New field `ID` in struct `PrivateLinkResource` info [Changelog] - New field `Name` in struct `PrivateLinkResource` info [Changelog] - New field `Type` in struct `PrivateLinkResource` info [Changelog] - New field `Allow` in struct `PrivateEndpointACL` info [Changelog] - New field `Deny` in struct `PrivateEndpointACL` info [Changelog] - New field `Error` in struct `ErrorResponse` info [Changelog] - New field `SystemData` in struct `Resource` info [Changelog] - New field `Kind` in struct `Resource` info [Changelog] - New field `Properties` in struct `Resource` info [Changelog] - New field `SKU` in struct `Resource` info [Changelog] - New field `Tags` in struct `Resource` info [Changelog] - New field `Identity` in struct `Resource` info [Changelog] - New field `Location` in struct `Resource` info [Changelog] - New field `Name` in struct `PrivateEndpointConnection` info [Changelog] - New field `Type` in struct `PrivateEndpointConnection` info [Changelog] - New field `ID` in struct `PrivateEndpointConnection` info [Changelog] - New field `ID` in struct `SharedPrivateLinkResource` info [Changelog] - New field `Name` in struct `SharedPrivateLinkResource` info [Changelog] - New field `Type` in struct `SharedPrivateLinkResource` info [Changelog] - New field `ID` in struct `ProxyResource` info [Changelog] - New field `Name` in struct `ProxyResource` info [Changelog] - New field `Type` in struct `ProxyResource` info [Changelog] info [Changelog] Total 313 breaking change(s), 307 additive change(s).
- Only show 60 items here, please refer to log for details.
️✔️armwebpubsub [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - New struct `PrivateEndpointConnectionsClientListResult` info [Changelog] - New struct `PrivateEndpointConnectionsClientUpdateOptions` info [Changelog] - New struct `PrivateEndpointConnectionsClientUpdateResponse` info [Changelog] - New struct `PrivateEndpointConnectionsClientUpdateResult` info [Changelog] - New struct `PrivateLinkResourcesClient` info [Changelog] - New struct `PrivateLinkResourcesClientListOptions` info [Changelog] - New struct `PrivateLinkResourcesClientListPager` info [Changelog] - New struct `PrivateLinkResourcesClientListResponse` info [Changelog] - New struct `PrivateLinkResourcesClientListResult` info [Changelog] - New struct `Properties` info [Changelog] - New struct `ResourceList` info [Changelog] - New struct `ResourceModel` info [Changelog] - New struct `SharedPrivateLinkResourcesClient` info [Changelog] - New struct `SharedPrivateLinkResourcesClientBeginCreateOrUpdateOptions` info [Changelog] - New struct `SharedPrivateLinkResourcesClientBeginDeleteOptions` info [Changelog] - New struct `SharedPrivateLinkResourcesClientCreateOrUpdatePoller` info [Changelog] - New struct `SharedPrivateLinkResourcesClientCreateOrUpdatePollerResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientCreateOrUpdateResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientCreateOrUpdateResult` info [Changelog] - New struct `SharedPrivateLinkResourcesClientDeletePoller` info [Changelog] - New struct `SharedPrivateLinkResourcesClientDeletePollerResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientDeleteResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientGetOptions` info [Changelog] - New struct `SharedPrivateLinkResourcesClientGetResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientGetResult` info [Changelog] - New struct `SharedPrivateLinkResourcesClientListOptions` info [Changelog] - New struct `SharedPrivateLinkResourcesClientListPager` info [Changelog] - New struct `SharedPrivateLinkResourcesClientListResponse` info [Changelog] - New struct `SharedPrivateLinkResourcesClientListResult` info [Changelog] - New struct `TLSSettings` info [Changelog] - New struct `UsagesClientListOptions` info [Changelog] - New struct `UsagesClientListPager` info [Changelog] - New struct `UsagesClientListResponse` info [Changelog] - New struct `UsagesClientListResult` info [Changelog] - New field `ID` in struct `PrivateLinkResource` info [Changelog] - New field `Name` in struct `PrivateLinkResource` info [Changelog] - New field `Type` in struct `PrivateLinkResource` info [Changelog] - New field `ID` in struct `ProxyResource` info [Changelog] - New field `Name` in struct `ProxyResource` info [Changelog] - New field `Type` in struct `ProxyResource` info [Changelog] - New field `Error` in struct `ErrorResponse` info [Changelog] - New field `Type` in struct `SharedPrivateLinkResource` info [Changelog] - New field `ID` in struct `SharedPrivateLinkResource` info [Changelog] - New field `Name` in struct `SharedPrivateLinkResource` info [Changelog] - New field `Deny` in struct `PrivateEndpointACL` info [Changelog] - New field `Allow` in struct `PrivateEndpointACL` info [Changelog] - New field `Type` in struct `PrivateEndpointConnection` info [Changelog] - New field `ID` in struct `PrivateEndpointConnection` info [Changelog] - New field `Name` in struct `PrivateEndpointConnection` info [Changelog] - New field `SKU` in struct `Resource` info [Changelog] - New field `Identity` in struct `Resource` info [Changelog] - New field `Location` in struct `Resource` info [Changelog] - New field `SystemData` in struct `Resource` info [Changelog] - New field `Properties` in struct `Resource` info [Changelog] - New field `Tags` in struct `Resource` info [Changelog] - New field `ID` in struct `TrackedResource` info [Changelog] - New field `Name` in struct `TrackedResource` info [Changelog] - New field `Type` in struct `TrackedResource` info [Changelog] info [Changelog] Total 363 breaking change(s), 356 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation
️✔️signalr [View full logs]️✔️webpubsub [View full logs] [Release Schema Changes]
|
Hi @juniwang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jan 5, 2022
This was referenced Jan 6, 2022
leni-msft
approved these changes
Jan 14, 2022
This was referenced Jan 14, 2022
Closed
This was referenced Jan 14, 2022
mstrisoline
pushed a commit
to mstrisoline/azure-rest-api-specs
that referenced
this pull request
Feb 1, 2022
…Azure#17228) * allow accessKeys to be readable * add x-ms-identifiers * remove x-ms-identifier
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…Azure#17228) * allow accessKeys to be readable * add x-ms-identifiers * remove x-ms-identifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
This PR is to fix swagger correctness issues. SignalR/Web PubSub access keys were wrongfully marked as write-only. However they should be able to GET by customers.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.