Skip to content

Commit

Permalink
Fix swagger correctness: secrets were wrongfully marked as write-only (
Browse files Browse the repository at this point in the history
…Azure#17228)

* allow accessKeys to be readable

* add x-ms-identifiers

* remove x-ms-identifier
  • Loading branch information
juniwang authored and LeiWang3 committed Mar 31, 2022
1 parent 83949e5 commit 1b4de04
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 40 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1923,38 +1923,22 @@
"primaryKey": {
"description": "The primary access key.",
"type": "string",
"x-ms-secret": true,
"x-ms-mutability": [
"create",
"update"
]
"x-ms-secret": true
},
"secondaryKey": {
"description": "The secondary access key.",
"type": "string",
"x-ms-secret": true,
"x-ms-mutability": [
"create",
"update"
]
"x-ms-secret": true
},
"primaryConnectionString": {
"description": "Connection string constructed via the primaryKey",
"type": "string",
"x-ms-secret": true,
"x-ms-mutability": [
"create",
"update"
]
"x-ms-secret": true
},
"secondaryConnectionString": {
"description": "Connection string constructed via the secondaryKey",
"type": "string",
"x-ms-secret": true,
"x-ms-mutability": [
"create",
"update"
]
"x-ms-secret": true
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2377,38 +2377,22 @@
"primaryKey": {
"description": "The primary access key.",
"type": "string",
"x-ms-secret": true,
"x-ms-mutability": [
"create",
"update"
]
"x-ms-secret": true
},
"secondaryKey": {
"description": "The secondary access key.",
"type": "string",
"x-ms-secret": true,
"x-ms-mutability": [
"create",
"update"
]
"x-ms-secret": true
},
"primaryConnectionString": {
"description": "Connection string constructed via the primaryKey",
"type": "string",
"x-ms-secret": true,
"x-ms-mutability": [
"create",
"update"
]
"x-ms-secret": true
},
"secondaryConnectionString": {
"description": "Connection string constructed via the secondaryKey",
"type": "string",
"x-ms-secret": true,
"x-ms-mutability": [
"create",
"update"
]
"x-ms-secret": true
}
}
},
Expand Down

0 comments on commit 1b4de04

Please sign in to comment.