Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recorder] Add support to skip recording the request body #20266

Closed
1 of 6 tasks
HarshaNalluru opened this issue Feb 8, 2022 · 1 comment
Closed
1 of 6 tasks

[Recorder] Add support to skip recording the request body #20266

HarshaNalluru opened this issue Feb 8, 2022 · 1 comment
Assignees
@timovv
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer test-utils-recorder Label for the issues related to the common recorder

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Feb 8, 2022 •
edited by timovv
Loading

Azure/azure-sdk-tools#2692 added support to skip recording the request body.

However, the docker image/tag is not published yet with that support.
Usage in .NET - https://github.com/Azure/azure-sdk-for-net/pull/26847/files

TODO

  • Wait for the new docker image/tag from ENG SYS
  • Add the feature to the recorder
  • Re-record form-recognizer tests with the new feature- specifically the sdk/formrecognizer/ai-form-recognizer/test/public/node/analysis.spec.ts
    • For perspective - png-test recording is of 6.8MB
  • Make sure the new recordings are smaller
  • Update the migration guide and docs to show the feature
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 8, 2022
@HarshaNalluru HarshaNalluru added the test-utils-recorder Label for the issues related to the common recorder label Feb 8, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer needs-team-triage Workflow: This issue needs the team to triage. labels Feb 8, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 8, 2022
@HarshaNalluru HarshaNalluru self-assigned this Feb 8, 2022
@HarshaNalluru HarshaNalluru added this to the [2022] April milestone Feb 9, 2022
@HarshaNalluru HarshaNalluru mentioned this issue Feb 9, 2022
Merged
@HarshaNalluru HarshaNalluru modified the milestones: [2022] May, [2022] June May 10, 2022
@xirzec xirzec removed the needs-team-triage Workflow: This issue needs the team to triage. label Jun 6, 2022
@HarshaNalluru HarshaNalluru modified the milestones: [2022] June, [2022] July Jun 7, 2022
@timovv timovv assigned timovv and unassigned HarshaNalluru Jun 15, 2022
@witemple-msft witemple-msft modified the milestones: 2022-07, 2022-08 Jun 29, 2022
@timovv timovv mentioned this issue Jul 4, 2022
Closed
@xirzec xirzec modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@timovv timovv modified the milestones: 2022-09, 2022-10 Aug 26, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Sep 19, 2022
@dtuCloud @shnaya434
@nimaller @jiaczh @jarango @sindhualuguvelli1 @jianzhao1992 @mchakka @bhavanabheem @3quanfeng @gitlwh @jago2136 @alon-microsoft @erichoffmannms @arganapathy @rahulbissa2727
CodeGen from PR 20695 in Azure/azure-rest-api-specs
9acb3a7 
Network 2022 05 01 (Azure#20695)

* Adds base for updating Microsoft.Network from version stable/2022-01-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* add DisableTcpStateTracking on nic (Azure#19734)

Co-authored-by: Dan Tu <dantu@microsoft.com>

* Adding new VIP Swap APIs to support extension resource design (Azure#19698)

* Adding new VIP Swap APIs to support extension resource design

* fixing validation checks

* minor fix

* Reverting changes

* Minor fix to add a new line

* fix description (Azure#19987)

Co-authored-by: Dan Tu <dantu@microsoft.com>

* Add BillingType Property to ExpressRoutePorts (Azure#19932)

* change port json

* changes

* add Virtual network gateway policy group api (Azure#19766)

* finish update on connection configuration references

* resolve reference error

* finish prettier

* resolve sematic error

* finish update change

* enablePrivateLinkFastPath property for VirtualNetworkGatewayConnection resource (Azure#20050)

* Support for Per Rule Actions in Application Gateway WAF (Azure#20027)

* Adding changes for per rule actions

* Fixing spaces

* prettier fix

* Addressing PR comments

* Address review comments

* Add ColoLocation to ExpressRoutePort result (Azure#20033)

* Add ColoLocation to ExpressRoutePort result

* Fix automation code check error

* Merge from network-2022-05-01

* Revert "Merge from network-2022-05-01"

This reverts commit f0671a040b2bad684921f8f8ad4b53bb0f4b4a93.

Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>

* DDoS Per IP SKU + Custom Policy Deprecation Swagger PR (Azure#19985)

* initial changes

* example file changes

* new files for new apis

* adding a period

* changing reference

* prettier fixes

* ddos fix

* lint diff fixes

* more lint diff errors

* fixing operation id

* changing bool to string enum

* example changes

* adding 202s as these are long running ops

* examples

Co-authored-by: Manas Chakka <manaschakka@microsoft.com>

* Adding UnhealthyThreshold property to LB health probes, and updated examples with new property (Azure#20001)

* Property to enable/disable OCSP revocation check on client certificate (Azure#20301)

* add new property to enable/disable OCSP revocation check on client certificate for MTLS

* revert breaking change of updating enum property

* Add new parameter asn, geo and expressRouteAdvertise to CustomIPPrefix for new 2022-05-01 nrp sdk version (Azure#20266)

* fix

* fix

* fix

* fix

* fix

* fix

Co-authored-by: Weiheng Li <weihl@microsoft.com>

* Network 2022-05-01 Azure Virtual Network Manager Contributions (Azure#20440)

* Add third NIP enum for avnm security admin config, AllowRulesOnly

* add optional top parameters to various network manager post APIs

* revise all example input subscriptions to all zero guid

* change all top parameter max value to 100

* Revert "change all top parameter max value to 100"

This reverts commit 12943d2f2b91b22f1dae232cb291a8551fedfdca.

Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>

* Alpelled waf manifest 05 01 2022 (Azure#20047)

* init

* init

* fix comments

* fix err

* try ref to appgw def

* try ref to appgw def

* try ref to appgw def

* try ref to appgw def

* update example

* update example

* update example

* update state and action

* update state and action

* change ruleset name and add tiers

* cammel case fix

* cammel case fix

* s_ruleid

* s_RuleId

* suppress s_RuleId camel case issue

* suppress s_RuleId camel case issue

* address comments

* address comments

* address comments

* fix typo

* cont fix

* cont fix

* cont fix

* cont fix

* cont fix

* add pageable

* add next link

Co-authored-by: Alon Pelled <alpelled@microsoft.com>

* Add prefixType property to CustomIPPrefix for NRP 2022-05-01 (Azure#20486)

* add prefixType parameter

* add example

* Adding swagger changes for routemaps feature (Azure#20091)

* initial changes for routemaps

* run npm prettier script

* adding examples

* fixing validation errors

* more validations

* more fixes

* trying to fix lint error

* fix for match condition

* renaming ActionType to fix lint

* fix for python sdk generation

* renaming Rule to RouteMapRule

* modify examples to remove vnetroutes from non hub vnet conns

* cleanup

* Added Upper-case transform (Azure#20674)

Co-authored-by: dtuCloud <tudan0103@gmail.com>
Co-authored-by: Dan Tu <dantu@microsoft.com>
Co-authored-by: shnaya434 <67019054+shnaya434@users.noreply.github.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: tyrannicrex <jiaczh@microsoft.com>
Co-authored-by: Jesus Arango <jearango@microsoft.com>
Co-authored-by: Sindhu Aluguvelli <sindhureddy216@gmail.com>
Co-authored-by: Jianqi Zhao <archie.j.zhao@gmail.com>
Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>
Co-authored-by: Manas Chakka <mchakka@gmail.com>
Co-authored-by: Manas Chakka <manaschakka@microsoft.com>
Co-authored-by: bhavanabheem <109241669+bhavanabheem@users.noreply.github.com>
Co-authored-by: biaogao <biga@microsoft.com>
Co-authored-by: Weiheng Li <weihengli.tj@gmail.com>
Co-authored-by: Weiheng Li <weihl@microsoft.com>
Co-authored-by: jago2136 <42753636+jago2136@users.noreply.github.com>
Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>
Co-authored-by: alon-microsoft <31221093+alon-microsoft@users.noreply.github.com>
Co-authored-by: Alon Pelled <alpelled@microsoft.com>
Co-authored-by: Eric Hoffmann <112216215+erichoffmannms@users.noreply.github.com>
Co-authored-by: arganapathy <109313670+arganapathy@users.noreply.github.com>
Co-authored-by: rahulbissa2727 <106511944+rahulbissa2727@users.noreply.github.com>
@timovv timovv modified the milestones: 2022-10, 2022-12 Oct 31, 2022
@xirzec xirzec modified the milestones: 2022-12, 2023-02 Jan 11, 2023
@xirzec xirzec removed this from the 2023-02 milestone Mar 31, 2023
@witemple-msft
Copy link
Member

This is no longer any factor as of migrating to the asset sync tool.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timovv timovv

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Recorder] Add support for skipping the request body timovv/azure-sdk-for-js
5 participants
@xirzec @timovv @HarshaNalluru @azure-sdk @witemple-msft