[Container Registry] Migrate to new recorder

[timovv]

Packages impacted by this PR

• @azure/container-registry

Issues associated with this PR

• [core-rest-pipeline] Make FetchClient the default browser httpclient #19859

Describe the problem that is addressed by this PR

Migrates ACR tests to the new recorder.

[timovv]

• add browser tests

[jeremymeng]

When I created the weekly live test pipeline, AZURE_*_* env vars didn't work for other clouds because they were set to the Public cloud's client/tenant. It is likely to be fixed now. Please trigger the js - container-registry - tests-weekly pipeline to make sure it's working. https://dev.azure.com/azure-sdk/internal/_build?definitionId=2886

[timovv]

I'll trigger that soon. I changed these back to their usual names so that the createTestCredential helper could be used -- it uses the standard names when creating the credential. If the issue still exists, then I can revert to using the CONTAINERREGISTRY_* names and switch between NoOpCredential and the DefaultAzureCredential without the helper.

[HarshaNalluru]

I didn't know this.

Maybe update the test-credential package to take more options?

[timovv]

Appears to be failing, I'll add an option to test-credential.

[jeremymeng]

We may want to fix the pipeline instead? I thought it is expected that Azure_* is set to be the ones from the cloud being tests against. @benbp

[jeremymeng]

Not blocking this PR. But I'd love to not special case ACR.

[timovv]

The change to add options to the test credential is nice to have anyway IMO regardless of whether we fix the underlying issue here.

[benbp]

We have not historically set AZURE_* variables and instead set namespaced variables like CONTAINERREGISTRY_* in the test infastructure to avoid potential collisions when running test batches. I have an issue to fix this though, as in practice it hasn't been an issue. A current workaround is to set a redirect in the pipeline definition, e.g. here.

        AZURE_CLIENT_ID: $(CONTAINERREGISTRY_CLIENT_ID)
        AZURE_TENANT_ID: $(CONTAINERREGISTRY_TENANT_ID)
        AZURE_CLIENT_SECRET: $(CONTAINERREGISTRY_CLIENT_SECRET)
        AZURE_SUBSCRIPTION_ID: $(CONTAINERREGISTRY_SUBSCRIPTION_ID)

[timovv]

/azp run js - container-registry - tests-weekly

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[timovv]

/azp run js - container-registry - tests-weekly

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[timovv]

/azp run js - container-registry - tests-weekly

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[joheredi]

Looks good to me!

[check-enforcer]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

[timovv]

/azp run js - container-registry - ci

[azure-pipelines]

No pipelines are associated with this pull request.