[Metrics Advisor] address some CR feedback to #11593 #11629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `*id` to just id for get/update/delete methods - also shorten `*ConfigurationId` to `*ConfigId` - Improve README - Swagger transform to add ref docs for `Metric` and `Dimension` - Swagger transform to remove `hook` prefix from `hookId` and `hookName` - Replace all `*DataFeedSourcePatch` types with a mapped type - Add missing DataFeed.creator property - Use mapped type for input of `create*()` methods instead of multiple ordered parameters. - Replace configuration patch types with mapped types from their full result types.
jeremymeng
requested review from
bterlson,
KarishmaGhiya and
xirzec
as code owners
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
*idto just id for get/update/delete methodsalso shorten
*ConfigurationIdto*ConfigIdImprove README
Swagger transform to add ref docs for
MetricandDimensionSwagger transform to remove
hookprefix fromhookIdandhookNameReplace all
*DataFeedSourcePatchtypes with a mapped typeAdd missing DataFeed.creator property
Use mapped type for input of
create*()methods instead of multiple ordered parameters.Replace configuration patch types with mapped types from their full result types.