Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics Advisor] address some CR feedback to #11593 #11629

Closed
wants to merge 1 commit into from

Commits on Oct 2, 2020

  1. Address some CR feedback to Azure#11593

    - Rename `*id` to just id for get/update/delete methods
    
    - also shorten `*ConfigurationId` to `*ConfigId`
    
    - Improve README
    
    - Swagger transform to add ref docs for `Metric` and `Dimension`
    
    - Swagger transform to remove `hook` prefix from `hookId` and `hookName`
    
    - Replace all `*DataFeedSourcePatch` types with a mapped type
    
    - Add missing DataFeed.creator property
    
    - Use mapped type for input of `create*()` methods instead of multiple ordered parameters.
    
    - Replace configuration patch types with mapped types from their full result types.
    jeremymeng committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    6338243 View commit details
    Browse the repository at this point in the history