Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] consolidate redundant tests #16689

Closed
kristapratico opened this issue Feb 10, 2021 · 2 comments
Closed

[formrecognizer] consolidate redundant tests #16689

kristapratico opened this issue Feb 10, 2021 · 2 comments
Assignees
@catalinaperalta
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Milestone
[2021] December

Comments

@kristapratico
Copy link
Member

We have a lot of redundant tests and should look into ways of consolidating them. With how many new features we are adding, our test suite is becoming unsustainable with live tests running for > 3 hours.
@kristapratico kristapratico added this to the [2021] March milestone Feb 10, 2021
@catalinaperalta
Copy link
Member

Addressed in part in #16715.

@lmazuel lmazuel added this to the [2021] December milestone Oct 7, 2021
@catalinaperalta catalinaperalta mentioned this issue Dec 1, 2021
Merged
@catalinaperalta catalinaperalta mentioned this issue Dec 10, 2021
Merged
@lmazuel lmazuel added the Client This issue points to a problem in the data-plane of the library. label Dec 17, 2021
@catalinaperalta
Copy link
Member

Test consolidation was completed during MQ and as part of the Test Proxy migration. The new beta design helped reduce tests with the omnibus analyze methods. Live tests should be running much less than 3 hours now.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Feb 28, 2022
@laithhisham @royrein @akning-ms
CodeGen from PR 17924 in Azure/azure-rest-api-specs
a49da55 
Dev securityinsights microsoft.security insights 2021 10 01 (Azure#17924)

* Adds base for updating Microsoft.SecurityInsights from version stable/2021-04-01 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AlertRules to microsoft.security insights 2021 10 01 (Azure#15657)

* Adds base for updating Microsoft.SecurityInsight's AlertRules from version stable/2020-01-01 to version 2021-10-01

* Updates API version in AlertRules specs and examples

* Use common types in AlertRules.json and remove redundant SecurityInsights

* Add AlertRules to readme

* Copy action examples for alert rules

* Add type:object where missing

* Align CloudError with rest of the resources in this version

* Update readme

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Use newest common types to align with rest of Azure (Azure#16130)

* Use newest common types to align with rest of Azure

* Use ErrorResponse instead of CloudError in operations

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Add AlertRules Stable version to 2021-10-01 (Azure#16268)

* Add AlertRules Stable version to 2021-10-01

* Fix missing alignment in common types

* prettier fixes

* move tactics and severity to common

* fix common types file extension

* more prettier fixes

* Add template version field

* prettier

* added version to required fields

* dummy change to trigger checks again

* Add onboarding states to new stable version (Azure#16290)

* Add onboarding states to new stable version

* Update readme.md

* cr fix - remove unused params

* Add missing resources 2021 10 01 (Azure#16666)

* Add missing resources and examples from 2020-01-01

* Update version in added resources and examples

* Use existing common types

* Remove unnesessary SecurityInsights.json

* Update readme

* Use sentinel common types in Incidents and Watchlist

* Extract and common IncidentInfo and IncidentSeverity

* Extract EntityTypes

* Correct double allOf in EntityTypes

* update readme

* Remove eventGroupingSettings and entityMappings from GetAlertRuleTemplateById example.

* rename operations.json

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Fix analytics templates model (Azure#16689)

* add missing properties to scheduled template

* prettier fixes

* restore templates example after merge

* fix templates example after merge and run prettier

* Use CloudError instead of ErrorResponse to align with preview versions and our back-end. (Azure#17472)

* Automation - Stable Version (Azure#17491)

* First

* readMe

* cloudError

* CloudError

* schema

* prettier

* Fix

* test

* fix identifier

* fix description

* fix lable

* fix lable

* ownerInfo

* Fix

* types

* conditionMaxLength

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Done (Azure#17728)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Correct 2021 10 01 (Azure#17830)

* Remove OperationalInsightsResourceProvider parameter in ThreatIntelligence

* Remove OperationalInsightProviderParameter from Watchlist

* Align stable operation names with preview

* Add missing disciminator property in ThreatIntelligence

* Done (Azure#17844)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Align enum names with preview (Azure#17831)

* Fix 2021 10 01 validation errors (Azure#17937)

* Add x-ms-identifiers to all arrays

* Add operations_list example

* Add x-ms-identifier in all arrays

* Run prettier

* Fix spelling error

* Add isDataAction to operation schema (Azure#18018)

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>
Co-authored-by: laithhisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: royrein <37300636+royrein@users.noreply.github.com>
Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@catalinaperalta catalinaperalta

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
[2021] December
Development

No branches or pull requests
3 participants
@lmazuel @catalinaperalta @kristapratico