Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication] - SDK - Added contributing file #18018

Merged

Conversation

jbeauregardb
Copy link
Contributor

No description provided.

@ghost ghost added the Communication label Apr 13, 2021
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch 2 times, most recently from ed83e98 to 02760ac Compare April 13, 2021 19:49
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch from 02760ac to 9ae040c Compare April 13, 2021 19:50

Once the package has been installed on your machine, let's jump on how to run the tests to see that everything is in order.

## Testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a reference to the general doc for live tests here

@jbeauregardb jbeauregardb marked this pull request as ready for review April 20, 2021 15:53
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch from cadf018 to e01c977 Compare April 20, 2021 17:47
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch from e01c977 to ddb77c0 Compare April 20, 2021 18:55
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch from ddb77c0 to 51cfd6e Compare April 20, 2021 18:56
Copy link
Member

@JoshuaLai JoshuaLai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with the changes!

@jbeauregardb jbeauregardb merged commit 16771a6 into Azure:master Apr 20, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Apr 22, 2021
…into azure_purview_catalog

* 'master' of https://github.com/Azure/azure-sdk-for-python: (205 commits)
  update FormField docstring (Azure#18226)
  [Event Hubs] combine conn str parsing logic (Azure#18059)
  [Blob]Edit Test for Single Thread Substream Retry (Azure#18206)
  maintenance changelog config (Azure#18216)
  Privated hierarchy traversal and fixed encryption algorithm (Azure#18212)
  Remove duplicate calls to bypass-local-dns.yml (Azure#18180)
  Patch changelog (Azure#18188)
  enable polling by default (Azure#18184)
  [Communication]: Added identity exception tests (Azure#18191)
  version (Azure#18202)
  [AutoRelease] t2-maintenance-2021-04-20-69227 (Azure#18166)
  Updated identity samples (Azure#18189)
  Sync eng/common directory with azure-sdk-tools for PR 1565 (Azure#18155)
  Clean Up PR Triggers (Azure#18186)
  [Tables] on a 413 throw a RequestEntity Too Large Error (Azure#18181)
  Add environment.yml to unify conda versioning (Azure#18141)
  [Fix]Add retry for streaming download (Azure#18164)
  Sync eng/common directory with azure-sdk-tools for PR 1558 (Azure#18178)
  Stop filtering projects by ci.yml files (Azure#18174)
  [Communication] - SDK - Added contributing file (Azure#18018)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 28, 2022
Dev securityinsights microsoft.security insights 2021 10 01 (Azure#17924)

* Adds base for updating Microsoft.SecurityInsights from version stable/2021-04-01 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AlertRules to microsoft.security insights 2021 10 01 (Azure#15657)

* Adds base for updating Microsoft.SecurityInsight's AlertRules from version stable/2020-01-01 to version 2021-10-01

* Updates API version in AlertRules specs and examples

* Use common types in AlertRules.json and remove redundant SecurityInsights

* Add AlertRules to readme

* Copy action examples for alert rules

* Add type:object where missing

* Align CloudError with rest of the resources in this version

* Update readme

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Use newest common types to align with rest of Azure (Azure#16130)

* Use newest common types to align with rest of Azure

* Use ErrorResponse instead of CloudError in operations

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Add AlertRules Stable version to 2021-10-01 (Azure#16268)

* Add AlertRules Stable version to 2021-10-01

* Fix missing alignment in common types

* prettier fixes

* move tactics and severity to common

* fix common types file extension

* more prettier fixes

* Add template version field

* prettier

* added version to required fields

* dummy change to trigger checks again

* Add onboarding states to new stable version (Azure#16290)

* Add onboarding states to new stable version

* Update readme.md

* cr fix - remove unused params

* Add missing resources 2021 10 01 (Azure#16666)

* Add missing resources and examples from 2020-01-01

* Update version in added resources and examples

* Use existing common types

* Remove unnesessary SecurityInsights.json

* Update readme

* Use sentinel common types in Incidents and Watchlist

* Extract and common IncidentInfo and IncidentSeverity

* Extract EntityTypes

* Correct double allOf in EntityTypes

* update readme

* Remove eventGroupingSettings and entityMappings from GetAlertRuleTemplateById example.

* rename operations.json

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>

* Fix analytics templates model (Azure#16689)

* add missing properties to scheduled template

* prettier fixes

* restore templates example after merge

* fix templates example after merge and run prettier

* Use CloudError instead of ErrorResponse to align with preview versions and our back-end. (Azure#17472)

* Automation - Stable Version (Azure#17491)

* First

* readMe

* cloudError

* CloudError

* schema

* prettier

* Fix

* test

* fix identifier

* fix description

* fix lable

* fix lable

* ownerInfo

* Fix

* types

* conditionMaxLength

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Done (Azure#17728)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Correct 2021 10 01 (Azure#17830)

* Remove OperationalInsightsResourceProvider parameter in ThreatIntelligence

* Remove OperationalInsightProviderParameter from Watchlist

* Align stable operation names with preview

* Add missing disciminator property in ThreatIntelligence

* Done (Azure#17844)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Align enum names with preview (Azure#17831)

* Fix 2021 10 01 validation errors (Azure#17937)

* Add x-ms-identifiers to all arrays

* Add operations_list example

* Add x-ms-identifier in all arrays

* Run prettier

* Fix spelling error

* Add isDataAction to operation schema (Azure#18018)

Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>
Co-authored-by: laithhisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: royrein <37300636+royrein@users.noreply.github.com>
Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants