get_client_from_cli_credentials and sovereign cloud on track2 #18553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
lmazuel
changed the title
xiangyan99
reviewed
May 6, 2021
| resource = scope[:-len(self._DEFAULT_PREFIX)] | ||
| else: | ||
| resource = scope | ||
| resource = self._profile.cli_ctx.cloud.endpoints.active_directory_resource_id |
There was a problem hiding this comment.
We don't need scopes any more?
There was a problem hiding this comment.
We extract it from CLI profile
|
Deprecating the factory instead #21337 |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Jun 24, 2022
Web ant97 2022 03 01 (Azure#19430) * Adds base for updating Microsoft.Web from version stable/2021-03-01 to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * Carry fwd Microsoft.CertificateRegistration and Microsoft.DomainRegis… (Azure#18460) * Carry fwd Microsoft.CertificateRegistration and Microsoft.DomainRegistration RPs to Api-version 2022-03-01 * Add x-ms-enum for array of inline enums. Fix reference to older api version for common defs * Add examples for App Service Certificate orders * Add suppressions back * Add examples for Microsoft.DomainRegistration RP * Fixes from prettier * Remove unused example * Add Unhealthy CustomDomainStatus for StaticSites (Azure#18557) * Adding VnetRouteAllEnabled, VnetImagePullEnabled, VnetContentShareEnabled site properties to CommonDefinitions (Azure#18627) * Added vnet realted site properties to common definitions * removed tab Co-authored-by: Tanay Bhartia <tanaybhartia@microsoft.com> * Add Ftp/Remote debug properties to Ase network config (Azure#18549) * Add Ftp/Remote debug properties to Ase network config * Switched changes to the right file * Add Networking config to hosting environment creates * Added some of the missing examples * Remove disallowed properties from example Ase GET response * Adjusted responses from other gets * Added a bunch more examples * Added other missing examples for Ase. * Added more missing examples for Ase. * fixed formatting * Edit some examples, add back privatelink apis and try to supress the errors for missing examples. * Fix suppress spelling and fix prettier * Added missing privatelink examples since suppressing did not work * Add Bring your own Backend operations (Azure#18517) * add bring your own backend operations * add missing files * fix json formattin * validation fixes * fix * fix more validation * fix ids * fix model validation * fix descriptions * fix environmentName description * change to 202 * revert change to 202 * customhostnamesites optional param for 2022 API version (Azure#18670) * fix DUPLICATE_PARAMETER * prettier * fix OBJECT_ADDITIONAL_PROPERTIES * fix random sub in examples * add optional hostname param to customHostnameSites RT and add examples * move changes from 2021 api version to 2022 * move examples to 2022 * Revert "add optional hostname param to customHostnameSites RT and add examples" This reverts commit 7fc318e190de2108222dbb869d9a6219a02cae2f. * remove examples from 2021 * fix lintDiff * prettier fix * model validation fix * suppress model validation in readme Co-authored-by: Elle Tojaroon <patojaro@microsoft.com> * [Microsoft.Web] Add CustomDnsSuffixConfiguration to ASE (Azure#18553) * [Microsoft.Web] Add CustomDnsSuffixConfiguration to AppServiceEnvironments * Add examples * Fix style issues * Add customdnssuffix to custom-words * Add CustomDnsSuffixConfiguration to AppServiceEnvironment definition * Address remaining model validation errors * Adjusted networking configuration definitions * Addressed Arm review feedback Co-authored-by: Jarod Aerts <jarodaerts@microsoft.com> * Fork/web ant97 2022 03 01 (Azure#19259) * Added DeploymentStatus API specs and examples * change status to enum, rm extra dot * suppress missing examples for now * rm id from List Deployment Slot examples * rm location, and rename deploymentId in GetSiteDeploymentStatus examples * change model as string to true, add 202 operations for DeploymentStatus ops to spec * rename operationId to deploymentStatusId, undo deploymentId rename * add long running op, as per linter Co-authored-by: Shubham Dhond <shdhond@microsoft.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> * PublicNetworkAccess Swagger Change (Azure#19352) * add publicNetworkAccess property in site for swagger * add suppression to fix Model Validation CI * Add allowed values in the description * Add specs for Hosting Environment Maintenance Control (Azure#18691) * Add documentation for Hosting Environment Maintenance Control * Update example file name * Make UpgradePreference non-nullable * Correct indentation to 2 spaces * Fix upgradePreference indentation * Address swagger feedback. Add enums with descriptions. * Move testNotification to request body. Update description text * Fix testNotification * Fix example * Replace TestNotification parameter with TestUpgradeNotification API * Rename to TestUpgradeAvailableNotification * Added logic apps operations (Azure#18604) * Added Initial Operations and some definitions * Adding additional objects to support Logic Apps operations * Updated path and parameters to match testing * Prettier Fixes * oav validat-example fixes * Github validation fixes * Prettier * Updated examples and paths * Prettier * Revert "Prettier" This reverts commit da090adf8005e0bd6fdc2ddebbd4390e5c4b6b20. * Prettier * Fixed model validation errors * Filled in nextLinkName values * Fixing swagger lintdiff errors * added x-ms-long-running to async calls * Adds numberOfWorkers to app service plan (Azure#19475) * Adds numberOfWorkers to app service plan * Add suppression for missing ASP examples * Updating to fix workflow errors (Azure#19490) * Removed conflicting resource definition and added reference to CommonDefinitions.json (Azure#19507) * Removed conflicting resource definition and added reference to CommonDefinitions.json * Updated resource to have workflow version * Updated nextLink object to be correctly tagged (Azure#19560) * Updated nextLink object to be correctly tagged * Adding value placeholder * Updated SKU to remove conflict * Updated x-ms-enum * Added missing model * Adding more missing models * Add suppressions for missing examples (Azure#19563) Co-authored-by: Joseph Lin <54335291+joslinmicrosoft@users.noreply.github.com> Co-authored-by: Tanay Bhartia <tanaybhartia@gmail.com> Co-authored-by: Tanay Bhartia <tanaybhartia@microsoft.com> Co-authored-by: JarodAertsMs <90280240+JarodAertsMs@users.noreply.github.com> Co-authored-by: annikel <92825476+annikel@users.noreply.github.com> Co-authored-by: Paviya (Elle) Tojaroon <pt335@cornell.edu> Co-authored-by: Elle Tojaroon <patojaro@microsoft.com> Co-authored-by: Chris Chen <chrc@microsoft.com> Co-authored-by: Jarod Aerts <jarodaerts@microsoft.com> Co-authored-by: edwin-msft <71858592+edwin-msft@users.noreply.github.com> Co-authored-by: Shubham Dhond <shdhond@microsoft.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: jiansong-msft <77516279+jiansong-msft@users.noreply.github.com> Co-authored-by: Derek Johnson <47129225+dejo-msft@users.noreply.github.com> Co-authored-by: Alex Karcher <alkarche@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix scope from track2 being in a different spot.
Really ARM focused, might be fine as a starting point since it's scoped to track2 and track2 data-plane are likely not compatible with this factory anyway