Deprecate CLI factory in azure-common #21337

lmazuel · 2021-10-19T20:06:11Z

See #20657 and #21313

franklsf95

typo

sdk/core/azure-common/azure/common/client_factory.py

lmazuel · 2021-10-19T21:36:35Z

Since this screenshot I changed it to NotImplementedError

scbedd · 2021-10-19T22:32:22Z

@praveenkuttappan APIView is getting its environments confused.

praveenkuttappan · 2021-10-20T00:16:05Z

API diff is a false alarm here since source branch in this case doesn't have recent change on main in storage packages. So artifact in this PR doesn't have this recent change which confuses APIView and flags it as removed in this PR. I will have a fix submitted to skip API check in PR if package is not modified. Currently this is triggered based on pipeline which doesn't make any sense for API check if source files are not modified.

sdk/core/azure-common/azure/common/credentials.py

sdk/core/azure-common/azure/common/client_factory.py

sdk/core/azure-common/azure/common/cloud.py

sdk/core/azure-common/azure/common/credentials.py

azure-sdk · 2021-12-16T23:46:19Z

API changes have been detected in azure-eventhub-checkpointstoreblob-aio. You can review API changes here

API changes

-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ..., 
-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ...,

azure-sdk · 2021-12-16T23:46:50Z

API changes have been detected in azure-eventhub-checkpointstoreblob. You can review API changes here

API changes

-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ..., 
-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ...,

lmazuel · 2021-12-17T20:50:59Z

/azp run python - tables - ci

lmazuel · 2021-12-17T20:51:10Z

/azp run python - core - ci

azure-pipelines · 2021-12-17T20:51:20Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2021-12-17T20:51:28Z

Azure Pipelines successfully started running 1 pipeline(s).

lmazuel · 2021-12-17T20:52:15Z

/azp run python - communication - ci

azure-pipelines · 2021-12-17T20:52:33Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2022-01-28T01:03:09Z

API changes have been detected in azure-cosmos. You can review API changes here

xiangyan99 · 2022-02-02T01:43:20Z

None of the failures is related to the change.

xiangyan99 · 2022-02-02T01:43:24Z

/check-enforcer override

@annatisch

* Deprecate CLI factory in azure-common * Correct syntax * ChangeLog * NotImplementedError * Deprecate all CLI related methods * Rewording * Date change * Typo thanks @annatisch * Typo * Fix tests * Update CHANGELOG.md Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>

Review request for Microsoft.ContainerService to add version 2022-10-02-preview (Azure#21439) * Adds base for updating Microsoft.ContainerService from version preview/2022-09-02-preview to version 2022-10-02-preview * Updates readme * Updates API version in new specs and examples * Pmiller/nodeosupgradechannel (Azure#21326) * missed working comment * matthew comments * unpatched is a word * Add MaintenanceWindow into MaintenanceConfigurationProperties (Azure#21337) * Add MaintenanceWindow into MaintenanceConfigurationProperties * Fx PrettierCheck * Fix ARM ID format for samples (Azure#21402) * Fix Swagger Model Validation for the 2022-10-02-preview dev branch of container service (Azure#21373) * fix API version * fix INVALID_FORMAT byte * fix INVALID_FORMAT arm-id * fix missing resource id * fix LRO_RESPONSE_HEADER * Update readmes for the 2022-10-02-preview dev branch of container service (Azure#21366) * update readmes * remove fleets * Updating abort apis response to make it long running (Azure#21362) * Updating response abort abort apis * Updating abort AP and MC examples * Changes per CI checks * Adding x-ms-long-running-operation-options * Adding location header Co-authored-by: InduSridhar <indusridhar@microsoft.com> * fix 202 location header * fix ProvisioningState validation * add x-ms-long-running-operation-options * fix ResourceNameRestriction * Fix abort location url in example (Azure#21446) * Updating response abort abort apis * Updating abort AP and MC examples * Changes per CI checks * Adding x-ms-long-running-operation-options * Adding location header * Fixing location url in abort examples Co-authored-by: InduSridhar <indusridhar@microsoft.com> * Abort api response fix (Azure#21559) * Updating response abort abort apis * Updating abort AP and MC examples * Changes per CI checks * Adding x-ms-long-running-operation-options * Adding location header * Fixing location url in abort examples * Fixing headers and body for abort response * Linter fix * Lint fix * Updating managedclusters.json responses Co-authored-by: InduSridhar <indusridhar@microsoft.com> * Node os upgrade desc fix (Azure#21636) * Updating response abort abort apis * Updating abort AP and MC examples * Changes per CI checks * Adding x-ms-long-running-operation-options * Adding location header * Fixing location url in abort examples * Fixing headers and body for abort response * Linter fix * Lint fix * Updating managedclusters.json responses * Minor edit to node os upgrade description based on ARM review Co-authored-by: InduSridhar <indusridhar@microsoft.com> Co-authored-by: Paul Miller <pmiller@microsoft.com> Co-authored-by: Thalia Wang <58485997+wenxuan0923@users.noreply.github.com> Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com> Co-authored-by: InduSridhar <InduSridhar@users.noreply.github.com> Co-authored-by: InduSridhar <indusridhar@microsoft.com>

lmazuel requested review from johanste, rakshith91 and xiangyan99 as code owners October 19, 2021 20:06

ghost added the Azure.Core label Oct 19, 2021

franklsf95 reviewed Oct 19, 2021

View reviewed changes

sdk/core/azure-common/azure/common/client_factory.py Outdated Show resolved Hide resolved

franklsf95 mentioned this pull request Oct 19, 2021

[Bug] Ray Autoscaler does not work with Azure due to deprecated method ray-project/ray#19523

Closed

2 tasks

This was referenced Oct 19, 2021

Fix get_client_from_cli_profile #20657

Closed

_retrieve_token() missing 1 required positional argument: 'token_resource' #21313

Closed

johanste reviewed Oct 20, 2021

View reviewed changes

sdk/core/azure-common/azure/common/credentials.py Outdated Show resolved Hide resolved

johanste reviewed Oct 20, 2021

View reviewed changes

sdk/core/azure-common/azure/common/credentials.py Outdated Show resolved Hide resolved

johanste reviewed Oct 20, 2021

View reviewed changes

sdk/core/azure-common/azure/common/credentials.py Outdated Show resolved Hide resolved

lmazuel force-pushed the cli_factory_deprecation branch from f2be066 to cbe29c4 Compare December 16, 2021 22:23

annatisch reviewed Dec 16, 2021

View reviewed changes

lmazuel mentioned this pull request Dec 16, 2021

get_client_from_cli_credentials and sovereign cloud on track2 #18553

Closed

Azure deleted a comment from azure-sdk Dec 16, 2021

lmazuel mentioned this pull request Dec 17, 2021

Extract Azure email from cli credentials #21561

Closed

annatisch approved these changes Dec 17, 2021

View reviewed changes

Deprecate CLI factory in azure-common

c2839db

lmazuel added 8 commits January 27, 2022 16:46

Correct syntax

bc77dc9

ChangeLog

c7bb91a

NotImplementedError

0027d1e

Deprecate all CLI related methods

2780de6

Rewording

f18f34f

Date change

02de0f5

Typo thanks @annatisch

1c9268c

Typo

82aa9ad

lmazuel force-pushed the cli_factory_deprecation branch from d0e6566 to 82aa9ad Compare January 28, 2022 00:46

lmazuel and others added 2 commits January 28, 2022 10:16

Fix tests

7f0e572

Update CHANGELOG.md

186521a

xiangyan99 merged commit 13950c4 into main Feb 2, 2022

xiangyan99 deleted the cli_factory_deprecation branch February 2, 2022 01:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate CLI factory in azure-common #21337

Deprecate CLI factory in azure-common #21337

lmazuel commented Oct 19, 2021

franklsf95 left a comment

lmazuel commented Oct 19, 2021 •

edited

Loading

scbedd commented Oct 19, 2021

praveenkuttappan commented Oct 20, 2021

azure-sdk commented Dec 16, 2021

azure-sdk commented Dec 16, 2021

lmazuel commented Dec 17, 2021

lmazuel commented Dec 17, 2021

azure-pipelines bot commented Dec 17, 2021

azure-pipelines bot commented Dec 17, 2021

lmazuel commented Dec 17, 2021

azure-pipelines bot commented Dec 17, 2021

azure-sdk commented Jan 28, 2022

xiangyan99 commented Feb 2, 2022

xiangyan99 commented Feb 2, 2022

Deprecate CLI factory in azure-common #21337

Deprecate CLI factory in azure-common #21337

Conversation

lmazuel commented Oct 19, 2021

franklsf95 left a comment

Choose a reason for hiding this comment

lmazuel commented Oct 19, 2021 • edited Loading

scbedd commented Oct 19, 2021

praveenkuttappan commented Oct 20, 2021

azure-sdk commented Dec 16, 2021

azure-sdk commented Dec 16, 2021

lmazuel commented Dec 17, 2021

lmazuel commented Dec 17, 2021

azure-pipelines bot commented Dec 17, 2021

azure-pipelines bot commented Dec 17, 2021

lmazuel commented Dec 17, 2021

azure-pipelines bot commented Dec 17, 2021

azure-sdk commented Jan 28, 2022

xiangyan99 commented Feb 2, 2022

xiangyan99 commented Feb 2, 2022

lmazuel commented Oct 19, 2021 •

edited

Loading