[Bug] Ray Autoscaler does not work with Azure due to deprecated method #19523
Comments
franklsf95
added
bug
|
Nice catch! Push a fix? |
|
@richardliaw I'm trying, but it doesn't look like there's a drop-in replacement for |
|
Hello, I'm the manager of the Azure Python SDK at MS, feel free to reach out to me by email (use my github alias and add microsoft.com at the end) if you need support on this and have questions. Long story short, we could have done better as a company here to make the deprecation story more visible, so I'm happy to help connect the dots if necessary. |
|
@lmazuel Thanks for following up on this! I'll be happy to work on a PR to fix this if I could get some help. There are only two callsites to I did not find much docs on |
|
So it used to be this: from azure.common.client_factory import get_client_from_cli_profile
from azure.mgmt.compute import ComputeManagementClient
client = get_client_from_cli_profile(ComputeManagementClient)and it should now be this: from azure.identity import AzureCliCredential
from azure.mgmt.compute import ComputeManagementClient
client = ComputeManagementClient(AzureCliCredential(), subscription_id)To get the default subscription: from azure.common.credentials import get_cli_profile
subscription_id = get_cli_profile().get_subscription_id() |
|
I can test this out Friday unless someone o wants to try it before then.
…On Tue, Oct 19, 2021, 9:51 PM Laurent Mazuel ***@***.***> wrote:
So it used to be this:
from azure.common.client_factory import get_client_from_cli_profile
from azure.mgmt.compute import ComputeManagementClient
client = get_client_from_cli_profile(ComputeManagementClient)
and it should now be this:
from azure.identity import AzureCliCredential
from azure.mgmt.compute import ComputeManagementClient
client = ComputeManagementClient(AzureCliCredential(), subscription_id)
To get the default subscription:
from azure.common.credentials import get_cli_profile
subscription_id = get_cli_profile().get_subscription_id()
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19523 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLUTWK2JMHBXGALJBDRPKTUHYOBRANCNFSM5GKAFHKA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
6 tasks
|
I'll take a stab at it today. |
|
Hey I got to it a bit earlier than expected.
…On Thu, Oct 21, 2021, 5:06 PM Frank Luan ***@***.***> wrote:
I'll take a stab at it today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19523 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLUTWOWP7PGHTAS3O3TPN3UIB6GNANCNFSM5GKAFHKA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Great! I'll leave it to you then. |
|
Hey, I am still getting this error. How to resolve this? |
|
Ugh. You're right we missed one. Will have time to look at it later this week. |
|
ok, sorry at first glance I assumed this was an issue with the changing sdk function names, but I don't believe that's the cause here. @bkpcoding can you tell me what version of azure python packages are being used with something like |
|
I am currently using ray version 1.9.1. As for the version azure, these are the versions |
|
got it thanks, yes the changes are not in 1.9.1 afaik. if you install from the latest wheel built from master does it work? |
|
Yes, it does, thank you! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Search before asking
Ray Component
Ray Clusters
What happened + What you expected to happen
ray up azure.yamlfails. See stack trace here Azure/azure-sdk-for-python#21313The reason is that MS is deprecating this method
get_client_from_cli_profile, see Azure/azure-sdk-for-python#21337Versions / Dependencies
Ray 1.7.0
Python 3.8.11
Latest install of
azure-climacOS
Reproduction script
ray up azure.ymlwhere the yml can be the example yaml fileAnything else
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: