Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PSBoundParameters later to make sure we pick up all changes #1177

Open
heaths opened this issue Nov 6, 2020 · 5 comments · Fixed by #1210
Open

Update PSBoundParameters later to make sure we pick up all changes #1177

heaths opened this issue Nov 6, 2020 · 5 comments · Fixed by #1210
Assignees
@heaths
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@heaths
Copy link
Member

heaths commented Nov 6, 2020

  • We need to update PSBoundParameters here.
  • And ProvisionerApplicationSecret and TenantId
  • TestApplicationOid is also updated later in the script.
  • BaseName is updated later as well.
  • As well as ResourceGroupName

Originally posted by @pakrym in #1175 (comment)
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 6, 2020
@heaths heaths self-assigned this Nov 6, 2020
@heaths heaths added bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. labels Nov 6, 2020
@heaths
Copy link
Member Author

heaths commented Nov 6, 2020

@benbp I'll let you get your work in first so this doesn't conflict. This issue shouldn't regress anything since people clearly weren't using "newly" added parameters, or they'd have been broken before. And my change that needs the $BaseName isn't going in until 1) the Az module is updated on agents, or 2) we have a story for prereq'ing newer Az modules (e.g. az.keyvault@3.0.0).

/cc @weshaggard @pakrym

@kurtzeborn kurtzeborn added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. Central-EngSys This issue is owned by the Engineering System team. labels Nov 10, 2020
heaths added a commit to heaths/azure-sdk-tools that referenced this issue Nov 13, 2020
@heaths
Make sure PSBoundParameters is correct
58971e1 
Fixes Azure#1177
@heaths heaths linked a pull request Nov 13, 2020 that will close this issue
Restore initial AzContext for New-TestResources #1210
Merged
@ghost ghost closed this as completed in #1210 Nov 16, 2020
@pakrym
Copy link
Contributor

pakrym commented Nov 16, 2020

@heaths, were you intending to close this?

@pakrym pakrym reopened this Nov 16, 2020
@heaths
Copy link
Member Author

heaths commented Nov 19, 2020

Yes, I fixed it with the latest changes we sync'd. I still kept updating of $PSBoundParameters closer to where we set/overwrote the variables because I still think it's more tenable than trying to remember all the variables we need to overwrite in $PSBoundParameters later, but the intent of this bug was addressed (i.e. I missed at least $BaseName).

@pakrym
Copy link
Contributor

pakrym commented Nov 19, 2020

I don't think so, there a few that are listed in the issue that are not updated.

@heaths
Copy link
Member Author

heaths commented Nov 19, 2020

I see: https://github.com/Azure/azure-sdk-tools/pull/1175/files#r518911288

sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this issue Dec 3, 2020
@azure-sdk
Sync eng/common directory with azure-sdk-tools repository for Tools P…
b765a6b 
…R 935 (Azure#1177)
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this issue Dec 3, 2020
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1210 (Azure#1515)
1f23377 
* Cache created service principal for iteration

Useful when testing changes over and over again without passing your own -TestApplicationId and -TestApplicationSecret.

* Restore initial AzContext for New-TestResources

* Make sure PSBoundParameters is correct

Fixes Azure#1177

Co-authored-by: Heath Stewart <heaths@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heaths heaths

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore initial AzContext for New-TestResources heaths/azure-sdk-tools
3 participants
@heaths @pakrym @kurtzeborn