Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we always log in as app or provisioner #1175

Merged
1 commit merged into from
Nov 6, 2020

Conversation

heaths
Copy link
Member

@heaths heaths commented Nov 6, 2020

This also adds previously-required parameters back into
@PSBoundParameters to pass down to pre- and post-scripts.

This also adds previously-required parameters back into
@PSBoundParameters to pass down to pre- and post-scripts.
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow


Log "Created service principal '$TestApplicationId'"
Log "Created service principal '$TestApplicationId'"
}

if (!$ProvisionerApplicationId) {
$ProvisionerApplicationId = $TestApplicationId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update PSBoundParameters here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And ProvisionerApplicationSecret and TenantId

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestApplicationOid is also updated later in the script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseName is updated later as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as ResourceGroupName

@ghost
Copy link

ghost commented Nov 6, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 5a7fd1c into Azure:master Nov 6, 2020
benbp pushed a commit that referenced this pull request Dec 1, 2020
This also adds previously-required parameters back into
@PSBoundParameters to pass down to pre- and post-scripts.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants