Optionally deploy activity log diagnostic settings beyond public and government

[shawngib]

Description

Current settings through error in clouds not supporting activity log diagnostic settings. Issue #453 tried setting diagnostic settings API to commonly supported version except the underlying API version doesn't support activity settings config. Its likely 453 can be reversed for now until clouds support this setting since the newer API supports it in public and gov clouds.

Steps to Reproduce

Steps to reproduce the behavior:

1. deploy to non-public/government cloud

Expected behavior

Diagnostic settings are created for activity logs to send to log analytics

Actual behavior

Error message suggesting activitylogdiagnosticsettingsconfig is unavailable.

Screenshots

Additional context

Further work should be created to track this missing capability, for now this is a work around to prevent error so the result will be no activity logs going to central logging.

Operating System:
Terraform Version:
Cloud (public, Azure Government, etc.):

[glennmusa]

I think opt-in central logging is the right call. 👍

But, unless there's some reason to change all diagnostic settings to an older provider, I don't think we need to revert #453 since the newer provider is already used everywhere else in source and known to work in deployments other than when it is necessary to opt-out of central logging.