Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the common diagnosticSettings provider version in central logging #453

Merged
merged 1 commit into from
Oct 12, 2021
Merged

use the common diagnosticSettings provider version in central logging #453

merged 1 commit into from
Oct 12, 2021

Conversation

glennmusa
Copy link
Contributor

Description

Updates the centralLogging.bicep module to use the provider version common across the solution and known to work in as many clouds as possible.

Issue reference

The issue this PR will close: #452

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa requested a review from a team October 12, 2021 19:40
@jjansen23 jjansen23 self-assigned this Oct 12, 2021
@glennmusa glennmusa merged commit f0e588d into main Oct 12, 2021
@glennmusa glennmusa deleted the glenn/updateDiagnosticLogVersion branch October 12, 2021 19:51
@shawngib shawngib mentioned this pull request Oct 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjansen23 jjansen23 jjansen23 approved these changes

Assignees

@jjansen23 jjansen23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a common Microsoft.Insights/diagnosticSettings version
2 participants
@glennmusa @jjansen23