Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set activity logging for supported clouds #478

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

shawngib
Copy link
Member

Description

Added simple verification on creating diagnostic settings to be sent to log analytics and storage which limits doing this to only public and government clouds.
if ( contains(supportedClouds, environment().name) ) where supportedClouds equals the array of clouds to support configurating this setting.

param supportedClouds array = [
  'AzureCloud'
  'AzureUSGovernment'
]

Issue reference

The issue this PR will close: #461

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@jjansen23
Copy link
Contributor

@shawngib - can you resolve the conflict in the branch ?

@shawngib
Copy link
Member Author

@shawngib - can you resolve the conflict in the branch ?

Solved

@glennmusa glennmusa merged commit 518afad into main Oct 25, 2021
@glennmusa glennmusa deleted the shawng/set_activity_logging_per_cloud branch October 25, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally deploy activity log diagnostic settings beyond public and government
3 participants