Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tier3 variables file #340

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Updating tier3 variables file #340

merged 2 commits into from
Aug 12, 2021

Conversation

Chambras
Copy link
Contributor

Description

  • Fixed some warning notifications due to missing types.
  • Added some default values to easy execute terraform apply for quick testing.
  • Added sensitive flags to some variables.
  • Updated some descriptions for better documentation.

Issue reference

NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa merged commit 7557a53 into Azure:main Aug 12, 2021
@Chambras Chambras deleted the VarCleanUp branch August 13, 2021 13:15
Breanna-Stryker added a commit that referenced this pull request Aug 26, 2021
* Updated contribution process (#309)

* allow users to bring their own credentials and override MLZ Service Principal creation (#315)

* Update Terraform to version 1.0.3 (#318)

Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>

* updated NOTICE to remove unused licenses (#321)

* Set missing provider on Sentinel LAWS (#326)

* Update Terraform to version 1.0.4 (#334)

* update terraform required version (#336)

* Updating mlz variables file (#338)

* Update azurerm provider to 2.71.0 (#339)

* Updating tier3 variables file (#340)

* Updated issue templates (#349)

- Changed 'Issue' type to 'Backlog Item'
- Consolidated 'Feature request' and 'Enhancement' into 'Enhancement'

* add CODEOWNERS file (#364)

* Updating some modules variables files (#363)

* Add NIST policy assignment off by default (#350)

Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Co-authored-by: Marcelo Zambrana Villarroel <marcech.am@gmail.com>
Co-authored-by: Steven St Jean <stestjea@microsoft.com>
Co-authored-by: Shawn Gibbs <shawngib@microsoft.com>
Breanna-Stryker added a commit that referenced this pull request Sep 2, 2021
* Update Terraform to version 1.0.4 (#334)

* update terraform required version (#336)

* Updating mlz variables file (#338)

* Update azurerm provider to 2.71.0 (#339)

* Updating tier3 variables file (#340)

* Updated issue templates (#349)

- Changed 'Issue' type to 'Backlog Item'
- Consolidated 'Feature request' and 'Enhancement' into 'Enhancement'

* add CODEOWNERS file (#364)

* Updating some modules variables files (#363)

* Add NIST policy assignment off by default (#350)

* Update Terraform to version 1.0.5 (#372)

* update the diagram (#383)

Co-authored-by: Marcelo Zambrana Villarroel <marcech.am@gmail.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Shawn Gibbs <shawngib@microsoft.com>
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants