Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated contribution process #309

Merged
merged 4 commits into from
Jul 29, 2021
Merged

Updated contribution process #309

merged 4 commits into from
Jul 29, 2021

Conversation

brooke-hamilton
Copy link
Contributor

Description

Please explain the changes you've made

Issue reference

The issue this PR will close: #233

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles or validates correctly
  • [ ] BASH scripts have been validated using shellcheck
  • [ ] All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@brooke-hamilton brooke-hamilton enabled auto-merge (squash) July 22, 2021 21:19
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for putting pen to paper

@brooke-hamilton brooke-hamilton merged commit aaa03b7 into main Jul 29, 2021
@brooke-hamilton brooke-hamilton deleted the brooke/contributing branch July 29, 2021 12:27
Breanna-Stryker added a commit that referenced this pull request Aug 26, 2021
* Updated contribution process (#309)

* allow users to bring their own credentials and override MLZ Service Principal creation (#315)

* Update Terraform to version 1.0.3 (#318)

Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>

* updated NOTICE to remove unused licenses (#321)

* Set missing provider on Sentinel LAWS (#326)

* Update Terraform to version 1.0.4 (#334)

* update terraform required version (#336)

* Updating mlz variables file (#338)

* Update azurerm provider to 2.71.0 (#339)

* Updating tier3 variables file (#340)

* Updated issue templates (#349)

- Changed 'Issue' type to 'Backlog Item'
- Consolidated 'Feature request' and 'Enhancement' into 'Enhancement'

* add CODEOWNERS file (#364)

* Updating some modules variables files (#363)

* Add NIST policy assignment off by default (#350)

Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Co-authored-by: Marcelo Zambrana Villarroel <marcech.am@gmail.com>
Co-authored-by: Steven St Jean <stestjea@microsoft.com>
Co-authored-by: Shawn Gibbs <shawngib@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the contributing guide to include the development process
2 participants