Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deploySentinel assignment in log analytics workspace module #468

Merged
merged 2 commits into from
Oct 18, 2021
Merged

update deploySentinel assignment in log analytics workspace module #468

merged 2 commits into from
Oct 18, 2021

Conversation

glennmusa
Copy link
Contributor

Description

Updates the solutions object in Log Analytics Workspace to evaluate whether or not to deploy Azure Sentinel

Issue reference

The issue this PR will close: #467

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa marked this pull request as draft October 18, 2021 15:03
@glennmusa glennmusa marked this pull request as ready for review October 18, 2021 15:05
@glennmusa glennmusa requested a review from a team October 18, 2021 15:05
@glennmusa glennmusa enabled auto-merge (squash) October 18, 2021 15:07
shawngib
shawngib approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@shawngib shawngib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly now with bicep version v0.4.1008 which induced the breaking change.

@glennmusa glennmusa merged commit bf43903 into main Oct 18, 2021
@glennmusa glennmusa deleted the glenn/updateDeploySentinel branch October 18, 2021 16:08
@ExchMaster ExchMaster mentioned this pull request Nov 11, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawngib shawngib shawngib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bicep deployment fails with InvalidTemplate on SecurityInsights
2 participants
@glennmusa @shawngib