Exposed 'deploySentinel' as an available parameter #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmusa
reviewed
Nov 11, 2021
src/bicep/mlz.bicep
Outdated
| @@ -487,6 +487,8 @@ param logAnalyticsWorkspaceLocation string = operationsLocation | |||
| param logAnalyticsWorkspaceCappingDailyQuotaGb int = -1 | |||
| param logAnalyticsWorkspaceRetentionInDays int = 30 | |||
| param logAnalyticsWorkspaceSkuName string = 'PerGB2018' | |||
| @description('When set to "True", enables Microsoft Sentinel within the MLZ Log Analytics workspace.') | |||
| param enableSentinel bool = false | |||
There was a problem hiding this comment.
let's name this deploySentinel for consistency -- the rest of the on/off switches are deploy{X}
There was a problem hiding this comment.
Yes sir, just updated the branch as requested. Thank you!
glennmusa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The module, "./src/bicep/modules/logAnalyticsWorkspace.bicep" parameter was set to 'False' and not exposed as param within mlz.bicep. This PR allows for setting this value to true as part of the base deployment of MLZ. This PR does not change the default behavior which is "deploySentinel = false".
Successfully tested the new param by setting it to 'true' and deploying a new MLZ instance in both Azure Commercial and Azure Government. Both deployments worked flawlessly and as expected with Azure Sentinel deployed successfully and collecting metrics appropriately.
Issue reference
The issue this PR will close: #405, this might also be seen as an update along with #468
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: