Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the main page documentation #587

Merged
merged 25 commits into from
Jan 4, 2022
Merged

Update the main page documentation #587

merged 25 commits into from
Jan 4, 2022

Conversation

brooke-hamilton
Copy link
Contributor

@brooke-hamilton brooke-hamilton commented Dec 17, 2021 •
edited
Loading

Description

  • Updates to README.md based on our current architecture and design goals
  • Update the scope image on README.md
  • Update the architecture diagram on README.md
  • Update the src/bicep/README.md file to include resourcePrefix in the sample commands.
  • Not in referenced issues: fixed a syntax error in the .github/CODEOWNERS file.

Issue reference

The issue this PR will close: #229
Also closes #568

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@brooke-hamilton brooke-hamilton marked this pull request as ready for review December 22, 2021 17:16
@brooke-hamilton brooke-hamilton changed the title [DRAFT] Update the main page documentation Update the main page documentation Dec 22, 2021
@brooke-hamilton brooke-hamilton enabled auto-merge (squash) December 22, 2021 17:17
@brooke-hamilton brooke-hamilton mentioned this pull request Dec 30, 2021
Merged
4 tasks
@glennmusa glennmusa self-assigned this Jan 4, 2022
glennmusa
glennmusa suggested changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo and a suggestion you can or don't have to accept. Thanks for the comprehensive update!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
brooke-hamilton and others added 2 commits January 4, 2022 10:00
@brooke-hamilton @glennmusa
Update README.md
c08dd57 
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
@brooke-hamilton @glennmusa
Update README.md
f110cf9 
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
@brooke-hamilton brooke-hamilton merged commit 3d0ca4c into main Jan 4, 2022
@brooke-hamilton brooke-hamilton deleted the brooke/mainpageupdates branch January 4, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmusa glennmusa glennmusa approved these changes

Assignees

@glennmusa glennmusa

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brooke-hamilton @glennmusa