Allow traffic between spokes by default #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
glennmusa
approved these changes
Jan 27, 2022
4 tasks
| ] | ||
| sourceIpGroups: [] | ||
| destinationAddresses: [ | ||
| '*' |
There was a problem hiding this comment.
Shoud this be the suprnetIpAddress range versus '*'? I believe right now this would technically allow all outbound traffic from the spokes, no?
There was a problem hiding this comment.
My thoughts exactly - this change allows all traffic within the VNets to access any address, including external, which breaks the "all other traffic is restricted by default" statement in https://github.com/Azure/missionlz/blob/main/README.md
@glennmusa @haithamshahin333 this looks like an unintended consequence of this change.
There was a problem hiding this comment.
Tagging @kyle-hoyer on this
There was a problem hiding this comment.
This does need to be changed. I will update. Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes include:
Allowing forwarded traffic by default
NSG allows traffic from peer spoke CIDR ranges
Firewall includes supernet rule to route traffic between spokes
Supernet parameter added for ease of use for end users
To test functionality, deploy MLZ, create VMs in two separate spokes, bastion into one and ping/ssh into the other VM.
Issue reference
The issue this PR will close: #608
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: