Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supernet address prefix parameter input to Portal UI #623

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented Jan 28, 2022

Description

A recent change #622 introduces a supernet to allow cross-spoke traffic.

This change updates the Portal UI to include an input for this value. It is set to the default in the template.

To demo this: https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fmain%2Fsrc%2Fbicep%2Fmlz.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fglenn%2FaddSupernetToUi%2Fsrc%2Fbicep%2Fform%2Fmlz.portal.json

Issue reference

The issue this PR will close: #608

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa glennmusa requested a review from a team as a code owner January 28, 2022 00:36
@glennmusa glennmusa enabled auto-merge (squash) January 28, 2022 00:43
Copy link
Contributor

@Breanna-Stryker Breanna-Stryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did an out of band deep dive on the validation logic, and tested in my environment, works great!

@glennmusa glennmusa merged commit 4181681 into main Jan 28, 2022
@glennmusa glennmusa deleted the glenn/addSupernetToUi branch January 28, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Allow traffic between spokes by default
2 participants