[Key Vault] Full LRO refactoring (Azure#12630)

* Secrets changes * some of the work, up to certificates * formatting * formatting on secrets * certificate changes * starting with keyvault admin * wip admin * builds and the review changes seem reasonable * formatting * formating on certificates * certificates fix * final touches * Simple changelog entries. * lint fix * Key Vault Secrets fix * secret fixes and better span titles
AzureSDKAutomation · Nov 25, 2020 · 6c6ce54 · 6c6ce54
1 parent caf3261
commit 6c6ce54
Show file tree

Hide file tree

Showing 43 changed files with 2,335 additions and 2,658 deletions.
diff --git a/sdk/keyvault/keyvault-admin/CHANGELOG.md b/sdk/keyvault/keyvault-admin/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## 4.0.0-beta.2 (Unreleased)
 
+- Updated the Key Vault Admin Long Running Operation Pollers to follow a more compact and meaningful approach moving forward.
 
 ## 4.0.0-beta.1 (2020-09-11)
 

diff --git a/sdk/keyvault/keyvault-admin/review/keyvault-admin.api.md b/sdk/keyvault/keyvault-admin/review/keyvault-admin.api.md
@@ -21,13 +21,7 @@ export interface BackupClientOptions extends coreHttp.PipelineOptions {
 }
 
 // @public
-export interface BackupOperationState extends PollOperationState<string> {
-    endTime?: Date;
-    jobId?: string;
-    startTime?: Date;
-    status?: string;
-    statusDetails?: string;
-}
+export type BackupOperationState = KeyVaultAdminPollOperationState<string>;
 
 // @public
 export interface BackupPollerOptions extends coreHttp.OperationOptions {
@@ -70,6 +64,15 @@ export class KeyVaultAccessControlClient {
     readonly vaultUrl: string;
 }
 
+// @public
+export interface KeyVaultAdminPollOperationState<TResult> extends PollOperationState<TResult> {
+    endTime?: Date;
+    jobId?: string;
+    startTime?: Date;
+    status?: string;
+    statusDetails?: string;
+}
+
 // @public
 export class KeyVaultBackupClient {
     constructor(vaultUrl: string, credential: TokenCredential, pipelineOptions?: BackupClientOptions);
@@ -142,12 +145,7 @@ export interface ListRoleDefinitionsPageSettings {
 }
 
 // @public
-export interface RestoreOperationState extends PollOperationState<undefined> {
-    endTime?: Date;
-    jobId?: string;
-    startTime?: Date;
-    status?: string;
-    statusDetails?: string;
+export interface RestoreOperationState extends KeyVaultAdminPollOperationState<undefined> {
 }
 
 // @public
@@ -157,12 +155,7 @@ export type RoleAssignmentScope = "/" | "/keys" | string;
 export const SDK_VERSION: string;
 
 // @public
-export interface SelectiveRestoreOperationState extends PollOperationState<undefined> {
-    endTime?: Date;
-    jobId?: string;
-    startTime?: Date;
-    status?: string;
-    statusDetails?: string;
+export interface SelectiveRestoreOperationState extends KeyVaultAdminPollOperationState<undefined> {
 }
 
 // @public

diff --git a/sdk/keyvault/keyvault-admin/src/accessControlClient.ts b/sdk/keyvault/keyvault-admin/src/accessControlClient.ts
@@ -33,7 +33,7 @@ import {
 } from "./accessControlModels";
 
 import { SDK_VERSION, LATEST_API_VERSION } from "./constants";
-import { createSpan, setParentSpan } from "./tracing";
+import { createSpan, setParentSpan } from "../../keyvault-common/src";
 import { mappings } from "./mappings";
 import { logger } from "./log";
 

diff --git a/sdk/keyvault/keyvault-admin/src/backupClient.ts b/sdk/keyvault/keyvault-admin/src/backupClient.ts
@@ -19,9 +19,15 @@ import { RestorePoller } from "./lro/restore/poller";
 import { SelectiveRestorePoller } from "./lro/selectiveRestore/poller";
 import { BackupOperationState } from "./lro/backup/operation";
 import { RestoreOperationState } from "./lro/restore/operation";
+import { KeyVaultAdminPollOperationState } from "./lro/keyVaultAdminPoller";
 import { SelectiveRestoreOperationState } from "./lro/selectiveRestore/operation";
 
-export { BackupOperationState, RestoreOperationState, SelectiveRestoreOperationState };
+export {
+  BackupOperationState,
+  RestoreOperationState,
+  SelectiveRestoreOperationState,
+  KeyVaultAdminPollOperationState
+};
 
 /**
  * The KeyVaultBackupClient provides methods to generate backups