Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorgranise and split-out export templates #3443

Closed
ssddanbrown opened this issue May 17, 2022 · 0 comments
Closed

Reorgranise and split-out export templates #3443

ssddanbrown opened this issue May 17, 2022 · 0 comments
Labels
🏭 Back-End 🔧 Maintenance
Milestone
v22.06

Comments

@ssddanbrown
Copy link
Member

We get a number of issues asking for tweaks to the PDF export format. #3440 and #3441 are recent examples of these.
While these could be customized using the visual theme system, the templates are currently a bit messy and wide-in-scope to make this easy.

To ease such customization, the export templates should be cleaned up and split into partials as much as possible where it makes sense. I started to do this in the PR that added PDF header/footer support but that branch was never merged.
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone May 17, 2022
@ssddanbrown ssddanbrown mentioned this issue May 17, 2022
Open
1 task
yangmx5 pushed a commit to yangmx5/BookStack that referenced this issue Jun 19, 2022
@ssddanbrown
Reorganised and split out export templates & styles
2451043 
Moved export templates elements into their own folder for better
grouping of logical usage.
Within the base export template, added some body classes to allow easier
targeted customisation via custom head css.
Split content of export templates into smaller partials for easier
future customization.

Closes BookStackApp#3443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏭 Back-End 🔧 Maintenance
Milestone
v22.06
Development

No branches or pull requests
1 participant
@ssddanbrown