Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCALE Updates #371

Merged
merged 4 commits into from
Nov 5, 2019
Merged

SCALE Updates #371

merged 4 commits into from
Nov 5, 2019

Conversation

ansermino
Copy link
Member

Changes

  • Fixes string decoding issues
  • Adds encode->decode test and fixes uncovered issues

Tests:

go test ./codec

Issues: closes #370

noot
noot approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@noot noot mentioned this pull request Nov 4, 2019
Merged
@ansermino ansermino merged commit 8fefce8 into development Nov 5, 2019
@ansermino ansermino deleted the david/string-decoding branch November 5, 2019 15:10
ryanchristo pushed a commit that referenced this pull request Jun 24, 2020
@ansermino @ryanchristo
SCALE Updates (#371)
d91e93b 
- Fixes string decoding issues
- Adds encode->decode test and fixes uncovered issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

@noot noot noot approved these changes

@dziabko dziabko Awaiting requested review from dziabko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scale decoding of strings in structs is not working
4 participants
@ansermino @dutterbutter @noot @ryanchristo