Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd, codec, config, trie: ignore unexported struct fields, change trie.Genesis to genesis.GenesisData #374

Merged
merged 7 commits into from
Nov 6, 2019

Conversation

noot
Copy link
Contributor

@noot noot commented Nov 4, 2019

Changes

  • update scale encode and decode to ignore unexported struct fields
  • remove trie.Genesis and create genesis.GenesisData which is the same as genesis.Genesis but with the initial state data unexported, since we don't need to store it in the DB again alongside the extra genesis data

note: depends on #371 and #369

Tests:

go test ./... -short

Issues:

closes #372 #373

@noot noot marked this pull request as ready for review November 4, 2019 22:09
Copy link
Member

@ansermino ansermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi I opened #391 to deal with some issues I discovered while reviewing this

cmd/gossamer/genesis.go Outdated Show resolved Hide resolved
config/genesis/genesis.go Show resolved Hide resolved
cmd/gossamer/genesis.go Outdated Show resolved Hide resolved
@noot noot merged commit aebd124 into development Nov 6, 2019
@noot noot deleted the noot/scale-unexported branch November 6, 2019 22:54
ryanchristo pushed a commit that referenced this pull request Jun 24, 2020
…e.Genesis to genesis.GenesisData (#374)

* update scale encode and decode to ignore unexported struct fields
* remove trie.Genesis and create genesis.GenesisData which is the same as genesis.Genesis but with the initial state data unexported, since we don't need to store it in the DB again alongside the extra genesis data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Genesis out of Trie Package
4 participants