Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daily prod fix: add rhel8 and rhel9 prodtypes to some rules #11296

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • Add rhel8 and rhel9 prodtypes to some rules which lost them during Update PCI-DSS profile for RHEL #11267
  • add warnings for rules which do not make sense on RHEL 8 or RHEL 9
  • remove such rules from PCI-DSS profile so that they stay in the datastream but they are not selected in any profile

Rationale:

In #11267 , prodtypes of some rules were made explicit. However, this caused them to be removed from RHEL 8 and RHEL 9 datastreams. This should not happen because of compatibility reasons.
Therefore, these rules stay in the datastream, but they are not selected in any profile.

Review Hints:

Try using utils/compare_ds.py with --only-rules switch.

@vojtapolasek vojtapolasek added RHEL9 Red Hat Enterprise Linux 9 product related. Update Rule Issues or pull requests related to Rules updates. Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. labels Nov 21, 2023
@vojtapolasek vojtapolasek added this to the 0.1.71 milestone Nov 21, 2023
@vojtapolasek vojtapolasek requested a review from a team as a code owner November 21, 2023 15:25
@vojtapolasek vojtapolasek changed the title add rhel8 and rhel9 prodtypes to some rules daily prod fix: add rhel8 and rhel9 prodtypes to some rules Nov 21, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt self-assigned this Nov 22, 2023
@marcusburghardt
Copy link
Member

The automatus tests failures are expected because the ntp package is not available in those systems. They can be safely waived here.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just an small comment to include the warning for sle15 too.

linux_os/guide/services/ntp/service_ntp_enabled/rule.yml Outdated Show resolved Hide resolved
@marcusburghardt marcusburghardt added the SLES SUSE Linux Enterprise Server product related. label Nov 22, 2023
Copy link

codeclimate bot commented Nov 22, 2023

Code Climate has analyzed commit 1c077d6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8%.

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt marcusburghardt merged commit 24c0340 into ComplianceAsCode:master Nov 22, 2023
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants