-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily prod fix: return rhel7 prodtypes to some rules #11303
Daily prod fix: return rhel7 prodtypes to some rules #11303
Conversation
also enhance the warning for rhel7 case
warnings: | ||
- general: | ||
{{% if prodtype == "rhel7" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better if the warning message would recommend to use the service_ntpd_enabled
rule instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I added it in 6e60138 ..
Code Climate has analyzed commit 6e60138 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5%. View more on Code Climate. |
The automatus tests failures are expected because the ntp package is not available in those systems. They can be safely waived here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's wait the CI tests to finish.
684285c
into
ComplianceAsCode:master
Description:
Rationale:
This is continuation of #11296