Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align rule audit_rules_privileged_commands_kmod #11320

Merged

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • remove explicit Ansible and Bash remediation
  • remove explicit OVAL check
  • remove explicit tests

Rationale:

  • the rule is templated but explicit content was overriding the template, not being aligned with rule description as well as security policies the rule is fullfilling (STIG, CIS)

Review Hints:

  1. Build old content
  2. read rule description and compare it with associated OVAL check and remediations
  3. build new content from this branch
  4. repeat step 2

@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. Update Rule Issues or pull requests related to Rules updates. labels Nov 30, 2023
@vojtapolasek vojtapolasek added this to the 0.1.72 milestone Nov 30, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 30, 2023

Code Climate has analyzed commit a769cb1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Nov 30, 2023

/packit retest-failed

@Mab879 Mab879 self-assigned this Nov 30, 2023
@Mab879
Copy link
Member

Mab879 commented Nov 30, 2023

/packit retest-failed

@marcusburghardt marcusburghardt merged commit a769cb1 into ComplianceAsCode:master Dec 1, 2023
36 of 38 checks passed
@marcusburghardt
Copy link
Member

Something weird happened here.

The commit in this PR was also included in the #11323.
I noticed the duplication after merging the #11323.

We could revert the #11323 to remove the duplication, but I don't think it is necessary. What do you think @Mab879 and @vojtapolasek ?

@marcusburghardt marcusburghardt self-assigned this Dec 1, 2023
@Mab879
Copy link
Member

Mab879 commented Dec 1, 2023

Something weird happened here.

The commit in this PR was also included in the #11323. I noticed the duplication after merging the #11323.

We could revert the #11323 to remove the duplication, but I don't think it is necessary. What do you think @Mab879 and @vojtapolasek ?

Looks like I messed up when I created by branch. But I think this PR is fine and we don't need a revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants