Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore mypy in the EOF Checker #11323

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Ignore mypy in the EOF Checker #11323

merged 3 commits into from
Dec 1, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Nov 30, 2023

Description:

  • Ignore mypy in the EOF Checker
  • Add some type hints

Rationale:

  • Remove race condition from the tests
  • Add more types hints for mypy to check

@Mab879 Mab879 added the Infrastructure Our content build system label Nov 30, 2023
@Mab879 Mab879 added this to the 0.1.72 milestone Nov 30, 2023
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 30, 2023

Code Climate has analyzed commit f68bead and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

marcusburghardt
marcusburghardt approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt
Copy link
Member

marcusburghardt commented Dec 1, 2023 •
edited
Loading

testing-farm failures are not related to this PR and can be safely waived here.

@marcusburghardt marcusburghardt merged commit 3c3b708 into ComplianceAsCode:master Dec 1, 2023
35 of 38 checks passed
@marcusburghardt marcusburghardt self-assigned this Dec 1, 2023
@marcusburghardt marcusburghardt mentioned this pull request Dec 1, 2023
Merged
@Mab879 Mab879 deleted the ignore_mypy_eof branch December 1, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
Infrastructure Our content build system
Projects
None yet
Milestone
0.1.72
Development

Successfully merging this pull request may close these issues.
3 participants
@Mab879 @marcusburghardt @vojtapolasek