-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of grub.d configs in grub2_bootloader_argument #11726
Conversation
Fixed failing check on Ubuntu when grub parameters were defined in /etc/default/grub.d/*cfg but not in /etc/default/grub. The fixed oval checks for the existence of the parameter in *either* /etc/default/grub or *at least one* /etc/default/grub.d/*cfg, ignoring loading order or overriden values. We can avoid the added complexity of checking the loading order and potentially overridden GRUB_CMDLINE_LINUX variables, because the tests with /etc/default/grub* are redundant to begin with. The OVAL checks also the parameters in the generated grub configs in /boot (as prescribed by CIS 1.0.0 for Ubuntu 22.04).
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit 62dafb1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description:
/etc/default/grub
or at least one/etc/default/grub.d/*cfg
, ignoring loading order or overriden values.Rationale: