-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression in grub2_bootloader_argument #11768
Conversation
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
/packit retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
/packit retest-failed |
@Mab879 it seems this packit test that is failing is unrelated to the PR. |
Agreed that test is unrelated. A rebase might fix it and recent PRs are passing. I would rather do that then override the tests. |
@mpurg could you please rebase it? |
Tests did not adequately cover all the scenarios.
This fixes a regression introduced in commit 62dafb1. The check passed even if the grub2 argument was not defined in /etc/default/grub nor in /etc/default/grub.d/*cfg. The correct behavior is to pass if it is defined in at least one configuration file.
803c0ab
to
73028d1
Compare
Code Climate has analyzed commit 73028d1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.3% (0.0% change). View more on Code Climate. |
/packit retest-failed |
Description:
grub2_bootloader_argument
on Ubuntu which was introduced in Fix handling of grub.d configs in grub2_bootloader_argument #11726Rationale: