Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of the most-used-rules and most-used-components subcommands of the profile_tool.py script to specify a list of products to be considered #11733

Merged
merged 11 commits into from
Mar 20, 2024

Conversation

Honny1
Copy link
Collaborator

@Honny1 Honny1 commented Mar 20, 2024

Description:

This PR extends the most-used-rules and most-used-components subcommands of the profile_tool.py script to specify a list of products to be considered.

The new --products flag allows users to get a list of the most used rules or components for Red Hat products only or other available products.

Depends on:

Review Hints:

To test new flag for most-used-rules you can use this command:

    $  ./build-scripts/profile_tool.py most-used-rules --products rhel9

To test new flag for most-used-components you can use this command:

    $  ./build-scripts/profile_tool.py most-used-components --products rhel9

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 20, 2024
Copy link

openshift-ci bot commented Mar 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11733
This image was built from commit: 352cfb9

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11733

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11733 make deploy-local

Copy link

codeclimate bot commented Mar 20, 2024

Code Climate has analyzed commit 352cfb9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

@Honny1 Honny1 added the enhancement General enhancements to the project. label Mar 20, 2024
@Honny1 Honny1 marked this pull request as ready for review March 20, 2024 15:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 20, 2024
@Honny1 Honny1 changed the title Extension of the most-used-rules and most-used-components subcommands of the profile_tool.py script to specify a list of products to be considered. Extension of the most-used-rules and most-used-components subcommands of the profile_tool.py script to specify a list of products to be considered Mar 20, 2024
@Mab879 Mab879 self-assigned this Mar 20, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Mar 20, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label Mar 20, 2024
@Mab879
Copy link
Member

Mab879 commented Mar 20, 2024

Waving the Windows build, fixed in #11734

@Mab879 Mab879 merged commit d24b09f into ComplianceAsCode:master Mar 20, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants