Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to use main branch and OpenSCAP 1.4.0 for building on Windows #11734

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Mar 20, 2024

Description:

Move to use main branch and 1.4.0 for building on Windows

Rationale:

Since OpenSCAP released a new version the version number will need to be updated.

@Mab879 Mab879 added the Infrastructure Our content build system label Mar 20, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Mar 20, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11734
This image was built from commit: 8f6b128

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11734

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11734 make deploy-local

@Mab879
Copy link
Member Author

Mab879 commented Mar 20, 2024

/packit build

@Mab879 Mab879 changed the title Move to use main branch and 1.4.0 for building on Windows Move to use main branch and OpenSCAP 1.4.0 for building on Windows Mar 20, 2024
Copy link

codeclimate bot commented Mar 20, 2024

Code Climate has analyzed commit 8f6b128 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator

We need to add information about what was wrong and why the Windows build started to fail to the PR description.

@Mab879
Copy link
Member Author

Mab879 commented Mar 21, 2024

We need to add information about what was wrong and why the Windows build started to fail to the PR description.

I have updated the description.

@jan-cerny jan-cerny self-assigned this Mar 22, 2024
@jan-cerny jan-cerny merged commit 1007d0f into ComplianceAsCode:master Mar 22, 2024
44 checks passed
@Mab879 Mab879 deleted the fix_opencap_version branch March 22, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants