Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require existence of /var/tmp/tmp-inst #11762

Merged

Conversation

jan-cerny
Copy link
Collaborator

We will not require the parent directory to exist, the OVAL test will pass also if the directory doesn't exist. It isn't mandatory to create the parent directory because when the directory doesn't exist, it gets created automatically by pam. However, if the parent directory exists, it must have correct mode, otherwise the polyinstantiation will fail.

This change is very similar to the change that we have done to the sister rule accounts_polyinstantiated_tmp in 13d2d86.

More context:
RHSecurityCompliance/contest#129 (comment)

We will not require the parent directory to exist, the OVAL test will
pass also if the directory doesn't exist.  It isn't mandatory to create
the parent directory because when the directory doesn't exist, it gets
created automatically by pam. However, if the parent directory exists,
it must have correct mode, otherwise the polyinstantiation will fail.

This change is very similar to the change that we have done to the
sister rule accounts_polyinstantiated_tmp in 13d2d86.

More context:
RHSecurityCompliance/contest#129 (comment)
@jan-cerny jan-cerny added the Update Rule Issues or pull requests related to Rules updates. label Mar 27, 2024
@jan-cerny jan-cerny added this to the 0.1.73 milestone Mar 27, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11762
This image was built from commit: 8f0e767

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11762

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11762 make deploy-local

Copy link

codeclimate bot commented Mar 27, 2024

Code Climate has analyzed commit 8f0e767 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Mar 27, 2024
@Mab879 Mab879 merged commit a3dfc44 into ComplianceAsCode:master Mar 27, 2024
44 checks passed
jan-cerny added a commit to jan-cerny/contest that referenced this pull request Mar 28, 2024
These Ansible remdiations have been added to upstream in these PRs:
- ComplianceAsCode/content#11762
- ComplianceAsCode/content#11763
comps pushed a commit to RHSecurityCompliance/contest that referenced this pull request Mar 28, 2024
These Ansible remdiations have been added to upstream in these PRs:
- ComplianceAsCode/content#11762
- ComplianceAsCode/content#11763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants