Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ansible Remediations #11763

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Add Ansible Remediations #11763

merged 1 commit into from
Mar 29, 2024

Conversation

jan-cerny
Copy link
Collaborator

This patch extends the Ansible remediations to RHEL 9:

  • force_opensc_card_drivers
  • dnf-automatic_apply_updates
  • dnf-automatic_security_updates_only

More context:
RHSecurityCompliance/contest#129 (comment)

@jan-cerny
Add Ansible Remediations
5210a71 
This patch extends the Ansible remediations to RHEL 9:
- force_opensc_card_drivers
- dnf-automatic_apply_updates
- dnf-automatic_security_updates_only

More context:
RHSecurityCompliance/contest#129 (comment)
@jan-cerny jan-cerny added the Ansible Ansible remediation update. label Mar 27, 2024
@jan-cerny jan-cerny added this to the 0.1.73 milestone Mar 27, 2024
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11763
This image was built from commit: 5210a71

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11763

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11763 make deploy-local

@codeclimate CodeClimate
Copy link

codeclimate bot commented Mar 27, 2024

Code Climate has analyzed commit 5210a71 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Mar 27, 2024
Mab879
Mab879 requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, however please open a PR for changing the wavier for this rule so they can be merged on the same day.

jan-cerny added a commit to jan-cerny/contest that referenced this pull request Mar 28, 2024
@jan-cerny
Remove waivers in Ansible remediations
1ff9339 
These Ansible remdiations have been added to upstream in these PRs:
- ComplianceAsCode/content#11762
- ComplianceAsCode/content#11763
@jan-cerny jan-cerny mentioned this pull request Mar 28, 2024
Merged
comps pushed a commit to RHSecurityCompliance/contest that referenced this pull request Mar 28, 2024
@jan-cerny @comps
Remove waivers in Ansible remediations
698040c 
These Ansible remdiations have been added to upstream in these PRs:
- ComplianceAsCode/content#11762
- ComplianceAsCode/content#11763
@Mab879
Copy link
Member

Mab879 commented Mar 28, 2024

/packit retest-failed

@Mab879 Mab879 merged commit 3363a2e into ComplianceAsCode:master Mar 29, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
Ansible Ansible remediation update.
Projects
None yet
Milestone
0.1.73
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-cerny @Mab879