Add option to override js_errors for phantomjs #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#64 This change enables users to tell **Quke** whether JavaScript errors in a web page should throw an exception, causing tests to fail. Based on current research this seems to be an option only available to people using [phantomjs](http://phantomjs.org/) (via [Poltergeist](https://github.com/teampoltergeist/poltergeist). Chrome and Firefox do not appear to provide flags that would cause an exception to be raised, or even an event we could capture and perhaps look to add the functionality into **Quke**. So this change - updates the `.config.yml` to add a new flag called `javascript_errors` - updates `driver_configuration.rb` to make use of this value when setting the **Poltergeist** options
Cruikshanks
added a commit
to DEFRA/quke-example
that referenced
this pull request
Jun 12, 2017
These changes were built more to enable me to test [Quke's new functionality](DEFRA/quke#65) which allows users to specify whether **PhantomJS** should throw an error if a JavaScript error is encountered. However it does also demonstrate how you can check for a certain exception within your test, and provide a page in the demo app with a JavaScript error to write your own tests against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64
This change enables users to tell Quke whether JavaScript errors in a web page should throw an exception, causing tests to fail.
Based on current research this seems to be an option only available to people using phantomjs (via Poltergeist. Chrome and Firefox do not appear to provide flags that would cause an exception to be raised, or even an event we could capture and perhaps look to add the functionality into Quke.
So this change
.config.ymlto add a new flag calledjavascript_errorsdriver_configuration.rbto make use of this value when setting the Poltergeist options