Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to override js_errors for phantomjs #65

Merged
merged 1 commit into from
Jun 12, 2017

Commits on Jun 12, 2017

  1. Add option to override js_errors for phantomjs

    #64
    
    This change enables users to tell **Quke** whether JavaScript errors in a
    web page should throw an exception, causing tests to fail.
    
    Based on current research this seems to be an option only available to
    people using [phantomjs](http://phantomjs.org/) (via
    [Poltergeist](https://github.com/teampoltergeist/poltergeist). Chrome
    and Firefox do not appear to provide flags that would cause an exception
    to be raised, or even an event we could capture and perhaps look to add
    the functionality into **Quke**.
    
    So this change
    
    - updates the `.config.yml` to add a new flag called `javascript_errors`
    - updates `driver_configuration.rb` to make use of this value when
      setting the **Poltergeist** options
    Cruikshanks committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    ead8be1 View commit details
    Browse the repository at this point in the history