Move proxy configuration to its own class #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change brings the proxy configuration inline with the other configuration blocks parallel and browserstack.
Cruikshanks
added
the
housekeeping
Also we have added a helper method to the proxy config class which handles the logic of returning a correctly populated hash of settings used when registering the firefox driver with Capybara. Admittedly this was mainly driven by CodeClimate kicking up a fuss, it at least means we can better test the different permutations that the settings hash can take based on the config values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings the proxy configuration inline with the other configuration blocks parallel and browserstack.