Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move proxy configuration to its own class #89

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Move proxy configuration to its own class #89

merged 2 commits into from
Mar 1, 2019

Commits on Mar 1, 2019

  1. Move proxy configuration to its own class 

    This change brings the proxy configuration inline with the other configuration blocks parallel and browserstack.
    @Cruikshanks
    Cruikshanks committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    8b92e99 View commit details
    Browse the repository at this point in the history

  2. Add a firefox driver settings helper to the config 

    Also we have added a helper method to the proxy config class which handles the logic of returning a correctly populated hash of settings used when registering the firefox driver with Capybara.

Admittedly this was mainly driven by CodeClimate kicking up a fuss, it at least means we can better test the different permutations that the settings hash can take based on the config values.
    @Cruikshanks
    Cruikshanks committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    cb7ad99 View commit details
    Browse the repository at this point in the history